badges
LOGS
18:59:47 <jflory7> #startmeeting Fedora Badges Bug Triage Session - 2016 Dec. 1
18:59:47 <zodbot> Meeting started Thu Dec  1 18:59:47 2016 UTC.  The chair is jflory7. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:59:47 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
18:59:47 <zodbot> The meeting name has been set to 'fedora_badges_bug_triage_session_-_2016_dec._1'
18:59:50 <jflory7> #meetingname badges
18:59:50 <zodbot> The meeting name has been set to 'badges'
18:59:54 <jflory7> #topic Agenda
18:59:55 <jflory7> #link https://fedorahosted.org/fedora-badges/report/25
18:59:58 <jflory7> #topic Roll call
18:59:59 <jflory7> .hello jflory7
19:00:00 <zodbot> jflory7: jflory7 'Justin W. Flory' <jflory7@gmail.com>
19:01:11 <sayan> .hello sayanchowdhury
19:01:12 <zodbot> sayan: sayanchowdhury 'Sayan Chowdhury' <sayan.chowdhury2012@gmail.com>
19:01:16 <jflory7> #chair sayan
19:01:16 <zodbot> Current chairs: jflory7 sayan
19:01:17 <jflory7> o/
19:01:22 <sayan> jflory7: o/
19:01:52 <jflory7> I'm not sure if anyone else was planning on coming, so I figure we may as well jump in and if anyone does arrive later, they can chime in any time. :)
19:02:05 <sayan> sure
19:02:48 <jflory7> Looks like 17 tickets to me. I'm not sure if we want to do this Hubs-style with running through them... I haven't been active with too many development meetings lately.
19:02:55 <jflory7> #topic Reviewing bug tickets
19:03:16 <sayan> jflory7: yeah we can go one by one
19:03:24 <jflory7> Okay, cool. Here goes:
19:03:29 <sayan> and take appropriate action for the ticket
19:03:30 <jflory7> #info === Ticket #106 ===
19:03:34 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/106
19:04:05 <jflory7> Hmmm... I feel like this is a sort of "wontfix" issue.
19:04:34 <jflory7> A three year old ticket, but I also don't know of anything that would make this possible. The best advice I would think of would be to contact the Design Team if one wanted to arrange for printed material
19:04:36 <sayan> Yeah! I think this is something that should go into tahrir
19:05:09 <jflory7> It would deserve special consideration too, because every major region in the world has different printing standards that make it difficult to follow a single, uniform format.
19:05:25 <sayan> This is something where he can export his/her badges and print it right
19:05:31 <jflory7> sayan: Okay, cool! Do you want to file the Tahrir issue and then close out this ticket afterwards?
19:05:35 <sayan> we can move this ticket to tahrir
19:05:38 <sayan> Yeah
19:05:42 <sayan> I'll do that
19:05:47 <jflory7> Okay, cool.
19:06:04 <jflory7> #action sayan File an upstream issue in Tahrir, close #106 with link to Tahrir issue
19:06:19 <jflory7> #info === Ticket #156 ===
19:06:23 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/156
19:06:48 <jflory7> Hmm, so adding multiple emails to a Tahrir profile.
19:06:57 <sayan> Yeah
19:07:00 <jflory7> I think this would be handy, and I can't imagine *too* difficult to do?
19:07:08 <jflory7> I can take care of this one pretty easily
19:07:30 <sayan> But we need a discussion for this ticket with the infra if it has any cons
19:07:35 <sayan> I don't think of any
19:07:47 <sayan> and needs a few changes in the code
19:07:50 <jflory7> #action jflory7 File upstream issue in Tahrir, close #156 with link to Tahrir issue
19:07:54 <sayan> This can also be migrated to tahrir
19:08:03 <jflory7> #info This ticket will need discussion about Infra team about any cons
19:08:13 <jflory7> Oh! And this issue might actually be super helpful!
19:08:26 <jflory7> With regards to the badges for Bugzilla coming up and linking emails that are different
19:08:53 <jflory7> #info === Ticket #269 ===
19:08:54 <sayan> hmm
19:08:54 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/269
19:09:27 <sayan> Maybe we can bump this ticket for comments
19:09:34 <jflory7> This is a ticket I think I could handle
19:09:43 <sayan> great
19:09:48 <jflory7> I see merit behind adding a link to the Vacations calendar. It was a question I had about where to find it when I first began contributing.
19:09:55 <jflory7> I should be able to edit the badge
19:10:19 <jflory7> #action jflory7 Review #269, edit Vacations badge with link to Vacations Fedocal, close ticket
19:10:31 <jflory7> That should be a quick one
19:10:47 <jflory7> #info === Ticket #270 ===
19:10:49 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/270
19:11:17 <jflory7> The ticket is two years old, so I'm not sure how mattdm might feel about this now... what are your thoughts, sayan?
19:11:39 <sayan> jflory7: we will do a revamp of the site
19:11:51 * jflory7 nods
19:11:56 <sayan> so maybe we can migrate this to tahrir too
19:12:11 <jflory7> So then this ticket is probably going to be invalid pretty soon. It might be good to request followup on this after the revamp.
19:12:37 <sayan> Yeah, I'll just migrate to tahrir so that I can comment after the revamp there itself
19:12:51 <jflory7> Okay, great. Will action this one to you.
19:13:06 <jflory7> #action sayan Review ticket #270, move to Tahrir, close Trac ticket
19:13:27 <jflory7> #info === Ticket #298 ===
19:13:29 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/298
19:13:43 <jflory7> Ooh, this is a good one
19:14:20 <jflory7> sayan: We could maybe tag-team this one. I can add the licensing information to the README for badges.git if you want to file a Tahrir issue to display this prominently on badges.fp.o.
19:14:20 <sayan> Yeah, we can add the LICENSE in the cgit repo
19:14:45 <sayan> Ok, I'll do that
19:14:49 <jflory7> Awesome!
19:15:02 <jflory7> #action jflory7 Update badges.git README to mention artwork licensing, add LICENSE file
19:15:25 <jflory7> #action sayan File upstream ticket in Tahrir for displaying CC-BY-SA 3.0 licensing info on badges.fp.o, close #298 afterwards
19:15:49 <jflory7> #info === Ticket #329 ===
19:15:50 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/329
19:16:18 <jflory7> This is one I'm not so sure on
19:16:45 <jflory7> It was never clarified if pingou's response there was the cause
19:17:17 <jflory7> Ohh, wait, I am misreading. He dug deeper to see if it was the cause, but found that caching wasn't at play...
19:17:34 <jflory7> So this still seems open
19:17:56 <jflory7> #link https://git.fedorahosted.org/cgit/badges.git/tree/rules/helping-hand.yml
19:18:39 <sayan> This would be hard job
19:18:46 <sayan> given this is a very old ticket.
19:19:25 <jflory7> sayan: This one might be better for you to tackle. I'm just not sure if it's a Tahrir issue or something with the rule file? And yeah, the age does make it difficult to troubleshoot. There's not any context if this was a repeating issue. I don't see any other tickets related to this, so it could very well be a one-off error...
19:19:32 <jflory7> Think we should just close it?
19:19:58 <sayan> jflory7: yeah
19:20:01 * jflory7 nods
19:20:02 <sayan> go ahead and close it
19:20:06 <jflory7> Okay, I can take care of this one
19:20:28 <jflory7> #action jflory7 Close #329 as 'wontfix' due to age and no other relevant info (e.g. reports of the same issue by others)
19:21:00 <jflory7> #info === Ticket #375 ===
19:21:02 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/375
19:21:15 <jflory7> I've noticed this issue before as well.
19:21:48 <jflory7> I think we will want to coordinate with the Design Team here to make sure we get the right artwork
19:22:19 <jflory7> We can ping riecatnor or mizmo on this one to try tackling in a badges meeting or at another time
19:22:54 * mizmo looking
19:23:16 <jflory7> mizmo: This is one of those easyfix tickets, but a lot of them shoved together into a single ticket, heh
19:23:26 <mizmo> i think it's just going to happen with contributors less familiar with the guidelines
19:23:27 <sayan> hehe
19:23:34 <jflory7> More tedious than anything.
19:23:45 <mizmo> but yes, these are great for first tasks / easy fix
19:24:09 <jflory7> Okay, cool, then perhaps this is a good thing to raise a flag for on the Design Team mailing list
19:24:30 <jflory7> I can do some follow-up in this ticket, but I think it's filed in the right place and probably won't be closed this week.
19:24:36 <mizmo> sure
19:25:10 * jflory7 is trying to do some of the more tedious tasks so sayan has more cycles to tackle the tickets that jflory7 has absolutely no idea on... :P
19:25:31 <jflory7> #action jflory7 Add a comment to #375, flag ticket as easyfix, triage as necessary
19:25:54 <jflory7> #info === Ticket #376 ===
19:25:57 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/376
19:26:52 <sayan> how many freemedia badges do we have in the series?
19:27:09 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora
19:27:29 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora-ii
19:27:31 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora-iii
19:27:32 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora-iiv
19:27:34 <jflory7> #undo
19:27:34 <zodbot> Removing item from minutes: <MeetBot.items.Link object at 0x10649b50>
19:27:37 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora-iv
19:28:00 <jflory7> #link https://badges.fedoraproject.org/badge/free-the-fedora-v
19:28:08 <jflory7> Looks like five
19:28:17 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/98
19:28:24 <sayan> yeah for 200 one receives a badge
19:28:36 <sayan> This also need cross-check
19:28:47 <jflory7> #link https://git.fedorahosted.org/cgit/badges.git/tree/rules/free-the-fedora.yml
19:29:03 <sayan> but same since the ticket is too old
19:29:17 <jflory7> I'm taking a guess the fedmsg crunching isn't right somewhere... it definitely doesn't seem like this badge is being awarded correctly.
19:29:35 <sayan> going through the datagrepper history would take a lot of time
19:29:59 <jflory7> sayan: Hmm, I feel like this one is still relevant? Some of the badges are definitely not being awarded as they should.
19:30:16 <jflory7> I think the fedmsg rule might need to be recalculated. That, or we should consider deprecating the badge
19:30:17 <sayan> jflory7: yeah
19:30:36 <sayan> Let me then write a script to check the data
19:30:53 <sayan> and cross check once
19:31:09 <sayan> if this wrong it could be the rule
19:31:11 <jflory7> Heh, actually... I think this badge will break again *anyways* too, since it seems to be dependent on Trac / FedoraHosted tickets
19:31:18 <jflory7> sayan: Think you want to investigate this one further?
19:31:28 <sayan> jflory7: sure
19:31:43 <sayan> freemedia migrated to pagure right?
19:31:46 <sayan> IIRC
19:31:52 <jflory7> #action sayan Investigate Free Media badges, determine if a fix needs to be made to rule file, update ticket as necessary
19:32:08 <jflory7> I think they did, actually... or were planning the migration
19:32:14 <jflory7> FranciscoD would definitely know this
19:32:19 <jflory7> He was leading the migration
19:32:42 <jflory7> Might be helpful to ping him about it to be sure. I think they have the Pagure created, but not yet migrated.
19:32:48 * FranciscoD peeks
19:33:00 <jflory7> FranciscoD: Ah, hey :)
19:33:03 <sayan> FranciscoD: hey
19:33:03 <FranciscoD> hiya
19:33:09 <jflory7> FranciscoD: Free Media has not yet fully migrated to Pagure yet, right?
19:33:13 <FranciscoD> Nope
19:33:16 <FranciscoD> We don't even have a plan yet
19:33:22 <sayan> Oh
19:33:25 <FranciscoD> As the ticket says, we're not sure if we can even
19:33:39 <FranciscoD> https://pagure.io/pagure/issue/1223
19:33:48 <jflory7> Hmm, okay. Maybe this is something CommOps can help plan with. Some of the new custom metadata features may make this possible, but I'm not sure about the anonymous submission form...
19:34:06 <FranciscoD> jflory7: we also need a system to mass close ticets
19:34:19 <FranciscoD> I close 1000s of them at a time usually once every few months
19:34:31 <jflory7> So there will likely be a delay on this one...
19:34:33 <FranciscoD> trac has batch modify etc - don't think pagure does
19:34:53 <jflory7> In either case, I'm inclined to say that it's filed in the right place, since the rule file will have to be rewritten for Pagure eventually, anyways
19:35:10 <FranciscoD> :)
19:35:14 <FranciscoD> Have a good meeting folks
19:35:17 <FranciscoD> jflory7++
19:35:17 <zodbot> FranciscoD: Karma for jflory7 changed to 8 (for the f25 release cycle):  https://badges.fedoraproject.org/tags/cookie/any
19:35:19 <FranciscoD> sayan++
19:35:21 <zodbot> FranciscoD: Karma for sayanchowdhury changed to 1 (for the f25 release cycle):  https://badges.fedoraproject.org/tags/cookie/any
19:35:31 * FranciscoD heads off into the darkness
19:35:35 <jflory7> FranciscoD++ Thanks for the quick response to the ping and adding the extra info.
19:36:14 <jflory7> sayan: We can revisit this ticket a little later on then, maybe after Free Media has figured out what their plan is. If the badge isn't working now and hasn't for years, I don't know what harm will wait until waiting until February to try fixing it for good then
19:36:20 <sayan> Yeah
19:36:26 <sayan> jflory7: just update the ticket there
19:36:36 <sayan> as a comment to the ticket
19:36:45 <jflory7> #agreed Since this ticket will block on Free Media migrating, we will revisit after February - jflory7 will update ticket
19:37:02 <jflory7> #action jflory7 Update ticket #376 with info about why we can't fix this yet
19:37:22 <jflory7> #info === Ticket #389 ===
19:37:23 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/389
19:37:28 <jflory7> Oh, this is another easy one
19:37:34 <sayan> This is a quick fix
19:37:36 <jflory7> I can do this today
19:37:43 * jflory7 nods
19:37:55 <jflory7> #action jflory7 Fix description with an apostrophe for #389
19:38:13 <jflory7> #info === Ticket #404 ===
19:38:14 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/404
19:38:30 <sayan> This badge seems to be working
19:38:35 <jflory7> Heh, yeah
19:38:42 <jflory7> So a happy and easy solution to this one
19:38:51 <jflory7> sayan: Do you want to grab this one really quick?
19:38:51 <sayan> 404 is the ticket number :p
19:38:56 <jflory7> I found that ironic too ;)
19:39:14 <sayan> We can close this one
19:39:42 <jflory7> Okay, great. Should be a super quick one.
19:39:57 <jflory7> #action sayan Close #404 as magically fixed \o/
19:40:04 <jflory7> #info === Ticket #423 ===
19:40:05 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/423
19:41:08 <jflory7> I feel like the ticket criteria field accurately solves this issue. I think I could close this ticket as wontfix, and if jibecfed feels it could still be better implemented, I'll instruct him to file an issue upstream in Tahrir.
19:41:13 <jflory7> Sound like a good plan?
19:42:15 <sayan> sure
19:42:40 <jflory7> Great!
19:43:00 <jflory7> #action jflory7 Close #423 as wontfix, explain why, point to upstream Tahrir if feels issue is not fully resolved
19:43:09 <jflory7> #info === Ticket #426 ===
19:43:11 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/426
19:43:51 <jflory7> #info The issue to this ticket is confirmed. If someone has a badge revoked, the "badge count" becomes incorrect and the badge will still be awarded if someone has 99 badges, but they had one revoked.
19:44:01 <sayan> anyways quest will be useful in the last ticket
19:44:04 <jflory7> sayan: I'm not sure if this issue falls in Tahrir counting badges or something in fedmsg.
19:44:31 <sayan> This should be a tahrir issue
19:44:37 * jflory7 nods
19:44:43 <jflory7> sayan: Want to head this one up?
19:45:07 <sayan> sure
19:45:27 <jflory7> #action sayan Migrate #426 from Trac ticket to Tahrir
19:45:54 <jflory7> #info === Ticket #449 ===
19:45:55 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/449
19:46:03 <sayan> I will look into it
19:46:18 <jflory7> #link https://git.fedorahosted.org/cgit/badges.git/tree/rules/fas-comeback.yml
19:46:28 <jflory7> Not sure if the rule file is helpful here or not.
19:46:32 <jflory7> Okay, will action this one to you.
19:46:48 <jflory7> #action sayan Investigate #449, update ticket with comment as necessary
19:47:12 <jflory7> #info === Ticket #497 ===
19:47:14 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/497
19:47:34 <jflory7> I personally agree, but to do this, it will require the badges to be redesigned, and then an Infra member will need to drop a tag.
19:47:41 <jflory7> A design team member should take a look at this first.
19:47:52 <jflory7> I will CC some design team members there to take a look at that one.
19:47:53 <sayan> RIght
19:48:06 <jflory7> #action jflory7 CC Design Team members for opinion / review on #497
19:48:30 <jflory7> #info === Ticket #498 ===
19:48:31 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/498
19:49:01 <jflory7> This definitely seems like a Tahrir ticket. :)
19:49:27 <jflory7> A good one too... I would see this being very helpful
19:49:28 <sayan> Yeah
19:49:35 <jflory7> sayan: Do you want to migrate this one?
19:49:37 <sayan> This is should be a tahrir ticket
19:49:42 <sayan> jflory7: okay
19:49:51 <sayan> I was thinking on the same lines
19:49:54 <jflory7> #action sayan Migrate #498 from Trac ticket to Tahrir issue
19:49:59 <jflory7> Perfect :)
19:50:14 <jflory7> #info === Ticket #501 ===
19:50:15 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/501
19:51:01 <jflory7> Hmmm. I'm at a loss for this one.
19:51:46 <sayan> I'll look into this
19:51:50 * jflory7 nods
19:52:08 <jflory7> #action sayan Investigate #501, update ticket with comment as necessary
19:52:18 <jflory7> #info === Ticket #504 ===
19:52:20 <jflory7> #link https://fedorahosted.org/fedora-badges/ticket/504
19:52:25 <jflory7> This is one I can definitely grab :)
19:52:41 <jflory7> #action jflory7 Award F24 release party organizer badge to FAS accounts in #504, close ticket after
19:52:46 <jflory7> #topic Open Floor
19:52:50 <jflory7> Phew!!
19:53:19 <jflory7> Got through them all with seven minutes to spare. Anything else you wanted to hit on now, sayan?
19:53:19 <sayan> :)
19:53:30 * jflory7 was trying to speed through there at the end so sayan could go sleep
19:53:39 <sayan> We can sometime go through the other badges
19:53:47 * jflory7 nods
19:53:50 <sayan> not now but sometime later
19:53:51 <sayan> :)
19:54:11 <jflory7> I think a large majority of these tickets will be closed this week. The remaining number will probably be enough that I can count on my fingers
19:54:24 <sayan> jflory7++
19:54:25 <zodbot> sayan: Karma for jflory7 changed to 9 (for the f25 release cycle):  https://badges.fedoraproject.org/tags/cookie/any
19:54:37 <sayan> Nothing else for open floor
19:54:45 <jflory7> sayan++ Thanks for staying up late and helping fly through these. :) If nothing else, enjoy your night!
19:54:46 <zodbot> jflory7: Karma for sayanchowdhury changed to 2 (for the f25 release cycle):  https://badges.fedoraproject.org/tags/cookie/any
19:54:48 <jflory7> #endmeeting