14:01:42 <andreasn> #startmeeting Cockpit weekly meeting 2016-02-29
14:01:42 <zodbot> Meeting started Mon Feb 29 14:01:42 2016 UTC.  The chair is andreasn. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:42 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
14:01:42 <zodbot> The meeting name has been set to 'cockpit_weekly_meeting_2016-02-29'
14:01:47 <andreasn> .hello andreasn
14:01:51 <zodbot> andreasn: andreasn 'Andreas Nilsson' <anilsson@redhat.com>
14:02:00 <dperpeet> .hello dperpeet
14:02:01 <zodbot> dperpeet: dperpeet 'None' <dperpeet@redhat.com>
14:03:28 <andreasn> #topic agenda
14:04:18 <dperpeet> * test cleanup
14:04:38 <dperpeet> * react (js)
14:05:52 <andreasn> I had some storage stuff, but that depends on Marius
14:05:57 <andreasn> so lets skip that for now
14:06:08 <andreasn> all right, lets start
14:06:19 <andreasn> #topic Test Cleanup
14:06:43 <dperpeet> stefw has added a few pull requests on this, some of them merged
14:07:10 <dperpeet> we split up our tests and added files all over the place, so this should be cleaner soon
14:07:43 <dperpeet> one notable change is in #3848 that lets the tests accept a machine (ip) to run the tests on
14:07:54 <dperpeet> #link https://github.com/cockpit-project/cockpit/pull/3848
14:07:59 <andreasn> neat
14:08:14 <dperpeet> there were mailing list questions regarding this
14:08:29 <dperpeet> that's partly why stef decided to do this now
14:08:38 <dperpeet> end of topic
14:08:53 <andreasn> #topic react(js)
14:09:11 <dperpeet> I've been poking at react in the last week or so
14:09:21 <dperpeet> and I'm using it in the wip-selinux troubleshooting branch
14:09:40 <dperpeet> I feel that it's less imposing on the rest of the code than angular
14:10:07 <dperpeet> and I feel like we should add compile-time support for jsx
14:10:46 <dperpeet> #link https://facebook.github.io/jsx/
14:10:47 <andreasn> this is probably the 3rd or 4th time I ask this, but I keep forgetting. What's jsx now again?
14:10:57 <andreasn> oh, right
14:10:59 <andreasn> thanks!
14:11:18 <dperpeet> the alternative is to just use these things locally
14:11:20 <dperpeet> during development
14:11:26 <dperpeet> as petervo suggested
14:11:39 <dperpeet> i.e. I write jsx but only commit the compiled code
14:11:54 <dperpeet> the lingo is to say "transpiled"
14:12:43 <andreasn> so <Dropdown> for example would turn into a whole html-thing?
14:12:58 <dperpeet> basically things in caps are custom-defined
14:13:29 <dperpeet> andreasn, something like this https://facebook.github.io/react/docs/tutorial.html#composing-components
14:14:06 <petervo> do we have to decide this now?
14:14:16 <dperpeet> no
14:14:20 <petervo> i'm not against it per se, it's just really big
14:14:32 <dperpeet> the question is: is there a reason not to even try this
14:14:38 <petervo> and with debian we have to have all the these things in the repo
14:14:40 <dperpeet> otherwise I would look into what it would actually entail
14:14:56 <dperpeet> hm
14:14:57 <petervo> and in the tar
14:15:00 <dperpeet> it could be just a dev time dep
14:15:07 <dperpeet> with an optional make step
14:15:17 <dperpeet> and we could commit jsx and the transpiled code
14:15:42 <dperpeet> and you only need that stuff if you want to change the jsx
14:16:32 <dperpeet> the readability of react is pretty limited without jsx
14:17:07 <dperpeet> an example from devconf: https://github.com/stefwalter/cockpit/commit/6c1dc3a2e9a9279c1c608bdfedc8106bdc01c150#diff-a572a924a17f210b406c1feffdd7d7fdR287
14:17:27 <petervo> what you are working on is pretty isolated, so i'd say do it however you want for now
14:17:47 <dperpeet> I'm going to develop it without jsx for now
14:17:59 <petervo> just keep it local until we use it in more than one package
14:18:05 <andreasn> the jsx markup looks pretty neat, easy to read
14:18:10 <petervo> then we'll need an official way
14:18:18 <dperpeet> but barring a veto, I'd like to see how much trouble it would be to have a converter
14:18:36 <cockpitbot> 1 tests failed - http://fedorapeople.org/groups/cockpit/logs/master-3ca99694-verify-debian-unstable/log.html
14:18:39 <petervo> i'm sure it's not too bad
14:18:47 <petervo> just a little big
14:18:54 <dperpeet> right now the only global change is pulling in react via bower
14:19:07 <petervo> but if it really makes things easier it's probably worth it
14:19:38 <dperpeet> well, I'll take this as a go-ahead to see how much we would actually need to add to get the converter/transpiler in
14:19:54 <andreasn> worth a shot
14:19:55 <dperpeet> it'll probably boil down to andreasn's decision
14:20:25 <dperpeet> looking like html but being different has it's downsides, too
14:20:30 <dperpeet> but this is all for now
14:20:43 <dperpeet> I'll tinker with it and we can decide once we have more facts and less conjecture
14:20:50 <dperpeet> thanks!
14:21:03 <andreasn> yeah, I agree that the code is easyish to read now, because it is divs with id's and classes
14:21:11 <andreasn> but yeah, lets see
14:21:15 <andreasn> #topic open floor
14:23:45 <andreasn> seems that's all.
14:24:08 <andreasn> #endmeeting