16:00:04 <Qalthos> #startmeeting Ansible Network Working Group
16:00:04 <zodbot> Meeting started Wed May 22 16:00:04 2019 UTC.
16:00:04 <zodbot> This meeting is logged and archived in a public location.
16:00:04 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:04 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:00:04 <zodbot> The meeting name has been set to 'ansible_network_working_group'
16:00:33 <Qalthos> #link https://github.com/ansible/community/labels/network is where you can find the agenda for this meeting
16:00:41 <Qalthos> #topic Core Updates
16:01:03 <Qalthos> #info Ansible 2.8 has been released!
16:03:20 <Qalthos> You can get it on PyPI, releases.ansible.com, github, and probably your distro's packages
16:05:19 <Qalthos> My understanding is that point releases of 2.7 and 2.6 are coming soon as well, and then backports will start flowing into 2.8 again
16:05:38 <Qalthos> So please bear with us if you have backports waiting for 2.8
16:06:13 <Qalthos> Let's get on to the agenda then!
16:06:28 <Qalthos> #topic Several Meraki PRs
16:07:00 <mrproper> First topic for Meraki PRs is a review of https://github.com/ansible/ansible/pull/48971. This has a depreciation notice added.
16:09:49 <Qalthos> mrproper: You should probably use `removed_in_version` in your argspec instead? https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#removed-in-version
16:10:43 <mrproper> That sounds right. I will make that change. Should I let you know when I update it for another review?
16:11:22 <Qalthos> Sure, you can ping me when it's done
16:11:36 <mrproper> Next PR.
16:12:12 <mrproper> https://github.com/ansible/ansible/pull/56525 should be ready to go. Github is having some problems so Shippable isn't blessing it, but if someone can review it and maybe restart CI.
16:13:24 <Qalthos> Oh boy, Shippable sure fell down on that one
16:13:28 <Qalthos> I've restarted the check
16:13:36 <mrproper> I already had it restarted once today, had that error twice already.
16:14:55 <mrproper> My final item for today is related to https://github.com/ansible/ansible/pull/55251. I'm new to unit tests and am really struggling with how to properly mock/patch fetch_url so I can test my module utility's reaction to different status codes. You'll see this PR has an example for 404 but when I run it, fetch_url still tries to make a real HTTP call.
16:15:40 <mrproper> If possible, I'd like some assistance with developing this test (and related tests if needed). I don't expect it to be completed during this WG session, so it's something to do later.
16:18:12 <Qalthos> I'm afraid I'm not a lot of help here, you might find better help in #ansible-devel on that sort of thing
16:19:31 <mrproper> Okay that's understood. That's all for me for this week. Thank you!
16:19:46 <Qalthos> Okay, moving on
16:19:56 <xuxiaowei0512> Please review and merge PR 55473. https://github.com/ansible/ansible/pull/55473
16:20:45 <Qalthos> #topic massive CloudEngine refactor
16:21:42 <xuxiaowei0512> My team is working hard to fix bugs for cloudengine.
16:21:59 <xuxiaowei0512> We found a lot of bugs, which are caused by sfotware version changes
16:22:19 <xuxiaowei0512> Please review and merge PR 55473
16:22:27 <xuxiaowei0512> This PR fixes many bugs
16:23:27 <Qalthos> So for my understanding
16:24:19 <Qalthos> Is QijunPan still attached to this project to give it a shipit?
16:24:54 <xuxiaowei0512> He is not active
16:25:04 <Qalthos> And are there other maintainers who might be able to comment?
16:25:44 <xuxiaowei0512> He is the only one
16:25:46 <Qalthos> You might want to also update https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml#L305 with active members to smooth the process along
16:26:17 <Qalthos> Alright then, that answers that then
16:26:27 <xuxiaowei0512> Yes,you are right
16:27:08 <Qalthos> I'll see if I can help this along then
16:27:39 <Qalthos> xuxiaowei0512: anything else?
16:27:40 <xuxiaowei0512> Thank you
16:27:58 <xuxiaowei0512> That is all for me
16:28:22 <Qalthos> #topic Lenovo backport
16:29:43 <Qalthos> Anil_Lenovo: Again, backports will resume when the release manager gets to them, which should be very soon now.
16:30:29 <Anil_Lenovo> Qalthos: Thanks. I will wait for that
16:30:59 <Qalthos> Unfortunately, there isn't anything in particular I can do to speed up this process, but as long as you respond to any comments he has on your PR, it should get into 2.8.1 with no issues
16:31:36 <Anil_Lenovo> yes. Will do so
16:31:47 <Qalthos> Anil_Lenovo: thanks
16:31:55 <Qalthos> #topic Open Floor
16:32:10 <Qalthos> Anyone have anything else they want to bring up here?
16:33:48 <ikhan> Anil_Lenovo: as Qalthos mentioned release manager is planning to go over 2.8.1 in next few days.  There is significant work going on behind the scenes, so please bare with us.  We will get to them as soon as we can.
16:35:28 <Anil_Lenovo> ikhan: Thanks. No issues. i will focus of few things like removal of providers from modules and Integration Tests in mean time
16:35:56 <Qalthos> Anil_Lenovo: I like the sound of both of those things :D
16:36:34 <Qalthos> If no one else has anything to bring up, I'll close this meeting in a few minutes
16:36:44 <Qalthos> Thanks to everyone who came out this week
16:40:16 <Anil_Lenovo> Have a great day ahead !
16:40:59 <Qalthos> #endmeeting