15:59:51 <Qalthos> #startmeeting Ansible Network Working Goup
15:59:51 <zodbot> Meeting started Wed May 15 15:59:51 2019 UTC.
15:59:51 <zodbot> This meeting is logged and archived in a public location.
15:59:51 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:59:51 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
15:59:51 <zodbot> The meeting name has been set to 'ansible_network_working_goup'
16:00:21 <Qalthos> #chair ganeshrn ikhan pabelanger privateip trishnag
16:00:21 <zodbot> Current chairs: Qalthos ganeshrn ikhan pabelanger privateip trishnag
16:00:33 <Qalthos> #topic Core Updates
16:01:13 <Qalthos> #info Ansible 2.8 is scheduled to release... tomorrow!
16:01:21 <grastogi> cheers!
16:01:22 <Qalthos> #link https://docs.ansible.com/ansible/devel/roadmap/ROADMAP_2_8.html
16:01:32 <Anil_Lenovo> Cheers !!
16:02:18 <Qalthos> Which means it's almost time for non-critical 2.8 backports to be able to be approved again
16:03:11 <Qalthos> Other than that, not much from the core team.
16:03:31 <Qalthos> #info 2.9 roadmap should be getting populated soon
16:03:40 <grastogi> one pull request which is blocking our development https://github.com/ansible/ansible/pull/54894 for 2.9
16:03:46 <Qalthos> I'll be sure to drop a link here when it is
16:04:42 <Qalthos> #link https://github.com/ansible/community/labels/network is where the agenda for this meeting can always be found
16:05:12 <Qalthos> And unless I am mistaken, there is only one item there for today
16:05:20 <Qalthos> #topic Meraki PRs
16:06:04 <mrproper> I saw one of my PRs I listed was merged a few minutes ago and another was approved.
16:06:16 <Qalthos> mrproper: I've had a look through your PRs, and the first thing I want to bring up is the commented out tests
16:06:27 <Anil_Lenovo> Qathos , what about my 56014 ?
16:06:59 <Anil_Lenovo> Qalthos: sorry for the typo
16:07:10 <mrproper> Qalthos: You're referring to 53575?
16:07:10 <Qalthos> Anil_Lenovo, Did that not get covered before? I can take that after, sorry
16:08:04 <Qalthos> mrproper, both 53576 and 56201 introduce new tests which are commented out
16:09:10 <mrproper> Qalthos: Starting with 53576. The tests that are commented out were existing but commented out. I can remove the comments and let you know after.
16:09:57 <Qalthos> Whoops, yes, those were preexisting
16:10:24 <mrproper> 56201 is a similar story. However...meraki_ssid's test is a little more complicated. Starting at line 318 will fail for now because it is dependent on another PR to be merged. If you'd prefer, I can work on getting that merged before we merge 56201.
16:13:22 <Qalthos> If it's dependent on another PR, I would probably just introduce it in the PR that enables it to work. If that means it makes more sense to hold 56201, then so be it, but a note in 48394 that new tests are added that now pass due to the PR is fine too
16:14:57 <mrproper> Okay. I'll probably hold a little on 56201 and get 48394 merged. 48394 should fix a bunch of problems for me that have become thorns in my side. So I'll focus on 48394 soon. Is there someone I should work with on review of 48394?
16:16:04 <mrproper> I'd like to close out discussion on 53576 as well. Are you happy with it or do you want me to fix the integration test comments? I'm happy either way.
16:17:46 <Qalthos> I would normally tell you to poke gundalow for getting reviews, but as he will be out for a while in the near future, let me check who to point you to
16:18:13 <mrproper> Thank you.
16:20:02 <Qalthos> As for 53576, remove or fix them as appropriate, but please do not commit commented tests, especially (though not exclusively) if they don't have any nearby explanation of why they are commented
16:20:24 <mrproper> Okay. I'll keep that in the future. I'll fix that and ping you on here?
16:20:33 <Qalthos> mrproper: sure
16:20:44 <mrproper> I think that covers all my items.
16:21:11 <Qalthos> #topic cnos_vrf backport
16:21:38 <Qalthos> Anil_Lenovo: Sorry for skipping you
16:23:50 <Anil_Lenovo> No issues
16:23:57 <Qalthos> As I mentioned at the start, 2.8 is releasing tomorrow, so backports have been only when absolutely needed for a few weeks
16:24:23 <Qalthos> I have four or five outstanding myself, waiting for 2.8.1
16:24:45 <Anil_Lenovo> Ok. It was discussed in last wednesday, that it can go in for 2.8.1
16:25:29 <Qalthos> They'll get reviewed after release and either merged or sent back for changes
16:25:58 <Anil_Lenovo> Sure, The status is displayed as Merging Blocked. Is it due to that ?
16:27:08 <Qalthos> The stable branches are all merging blocked, always. I can't even merge into stable-2.8. It is up to the release manager to merge or reject any bakports that come in
16:28:33 <Qalthos> Hopefully sometime next week we'll start to see backports getting merged again
16:29:20 <Qalthos> I couldn't tell you specifically when, but you should see an update on your PR soon
16:29:31 <Anil_Lenovo> sure. which means that status may change next week possibily right ?
16:30:12 <Qalthos> That's what I'm expecting.
16:30:38 <Anil_Lenovo> i will focus on posting roles in Galaxy in the meantime then.
16:31:00 <Anil_Lenovo> Thank you, Qalthos.
16:31:15 <Qalthos> Anil_Lenovo: You're welcome
16:31:39 <Qalthos> #topic Avi update
16:32:08 <Qalthos> grastogi: I know this has been going on for a while. I will personally make sure something happens to this today
16:33:37 <grastogi> thanks a lot! If needed, I can do a conf call to walk through all the changes. It is porting of a stable API code into ansible core. A lot of customers are using Tower now and they don't like using Galaxy Roles.
16:36:23 <Qalthos> #topic Open Floor
16:36:49 <Qalthos> Anyone else here who has something to bring up?
16:44:50 <Qalthos> Right, then, I'll close 15 minutes early
16:44:57 <Qalthos> Have a good week everyone!
16:45:01 <Qalthos> #endmeeting