16:00:36 <Qalthos> #startmeeting Ansible Network Working Group
16:00:36 <zodbot> Meeting started Wed Feb 27 16:00:36 2019 UTC.
16:00:36 <zodbot> This meeting is logged and archived in a public location.
16:00:36 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:36 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:00:36 <zodbot> The meeting name has been set to 'ansible_network_working_group'
16:01:04 <Qalthos> #chair ganeshrn ikhan jungleslow privateip trishnag pabelanger
16:01:04 <zodbot> Current chairs: Qalthos ganeshrn ikhan jungleslow pabelanger privateip trishnag
16:01:22 <Qalthos> #unchair jungleslow
16:01:22 <zodbot> Current chairs: Qalthos ganeshrn ikhan pabelanger privateip trishnag
16:01:29 <Qalthos> #chair justjais
16:01:29 <zodbot> Current chairs: Qalthos ganeshrn ikhan justjais pabelanger privateip trishnag
16:01:48 <Qalthos> One day I will manage to get that first try
16:01:59 <Qalthos> #topic Core Updates
16:02:07 <Qalthos> #info added keypair management to cloud vpn provisioners
16:02:28 <Qalthos> specifically: AWS, working on OpenStack, Azure is noop since keypairs are servers properties instead of API objects
16:02:35 <Qalthos> #info working on saving tunnels facts when processing lists of tunnel configs
16:02:43 <Qalthos> #info Included support of Cisco_ftd under acl_manager role
16:02:50 <Qalthos> #info gRPC connection plugin added (ansible/ansible#52823)
16:02:57 <Qalthos> #info grpc_nw_get module to work with iosxr 9k (ansible/ansible#52857)
16:03:51 <Qalthos> #info restconf_config module (ansible/ansible#51971)
16:04:42 <Qalthos> #link https://github.com/ansible/community/labels/network is where you can always find the current agenda
16:06:10 <Qalthos> Speaking of which, here is one of the people who added to the agenda
16:06:22 <Qalthos> #topic cnos_logging
16:06:29 <Anil_Lenovo> Hi
16:06:43 <Qalthos> Anil_Lenovo: I have had only a cursory look at it so far, but it seems fine
16:08:00 <Anil_Lenovo> yes, I tried to realize the same module as that of IOS. But our logging command structure has some differences. Accommodating them I have completed the module
16:08:14 <Anil_Lenovo> It has been tested on Mars 10.9.1 of Lenovo
16:08:42 <Anil_Lenovo> We dont have a global on/off command for logging. So omitted that
16:08:55 <Anil_Lenovo> Instead of host, we have command server
16:09:13 <Anil_Lenovo> instead of buffer, we have logfile
16:09:29 <Anil_Lenovo> but functinality are all the same
16:10:43 <Federico87_> \\\\
16:11:05 <Qalthos> Anil_Lenovo: Sounds fine. I'll take a closer look at it after this is over
16:11:50 <Anil_Lenovo> Sure..Thank you!
16:12:24 <Qalthos> Alright, next up
16:12:47 <Qalthos> #topic New module asa_og
16:13:23 <Qalthos> Federico87_: So issue number 1 is that `cmp()` does not exist anymore as of Python 3
16:14:20 <Federico87_> Make sense now :)
16:15:05 <Qalthos> I don't see why `lines != sorted(have_lines)` wouldn't work in this case
16:15:06 <Federico87_> So I believe I have to replace that bit
16:15:34 <Federico87_> don't remeber on top of my head now but I will give a try
16:15:37 <Qalthos> But I don't know precisely what you're doing in there that might have issues with comparing by equality
16:16:06 <Qalthos> Is there anything else you wanted to bring up about the module?
16:16:30 <Federico87_> at the moment no, thanks. I' ll work on that ;)
16:18:13 <ankitb_07> Regarding module "[ansible/ansible#51238](https://github.com/ansible/ansible/pull/51238)"
16:18:58 <ankitb_07> I created the module, the tests passed successfully. But when I added the unit tests that references the the new module, I get an import error.
16:19:23 <Qalthos> Federico87_: Alright. Nilashish should be giving your PR a review soon, he'll likely bring that up as well.
16:19:42 <ankitb_07> Please if some one can review that for me. Or should I ignore unit tests for the new module.
16:19:48 <ankitb_07> Thanks, appreciate it.
16:20:12 <Qalthos> #topic New module itential iap_start_workflow
16:20:59 <ankitb_07> We can skip that as we already discussed about that PR.
16:23:25 <ankitb_07> Question: Can i add multiple new modules at once?
16:24:23 <samccann> does this link help - https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_in_groups.html#developing-modules-in-groups
16:24:58 <ankitb_07> TY.
16:25:37 <Qalthos> For your first question, `patch()` generally needs the whole path to the module, even if you've imported it under a shorter name
16:25:53 <resmo> hi
16:26:32 <Qalthos> Use the whole string starting from 'ansible.modules' and it should work, I think
16:27:10 <ankitb_07> Cool, I will give it a try. Thanks.
16:27:19 <Qalthos> resmo: Did you have something for this meeting?
16:28:01 <resmo> pabelanger, may a direct query you for a question regarding zuul integration for proprietary cloud apis?
16:29:02 <resmo> Qalthos, there is a meeting? sorry no. ignore me :)
16:29:09 <pabelanger> resmo: sure, after the current meeting?
16:29:14 <resmo> pabelanger, sure
16:29:36 <Qalthos> Right, I see mikewiebe also snuck something onto the agenda
16:29:37 <mikewiebe> Yes, https://github.com/ansible/ansible/pull/52883
16:29:41 <mikewiebe> :)
16:29:50 <Qalthos> #topic nxos_logging fixes
16:30:39 <mikewiebe> Qalthos: trishnag asked for your review on the PR
16:30:53 <Qalthos> I can take a look at that. Is there anything in particular you'd like to mention?
16:32:30 <mikewiebe> The only thing is that I had to convert the nxapi payload to use an ordered dict.  Some older NX-OS platforms have an ordering issue when processing the payload
16:32:59 <mikewiebe> That impacts more then just nxos_logging but we ran the changes through our entire test suite and matrix
16:33:38 <mikewiebe> That change is in module_utils and httpapi for nxos
16:34:10 <Qalthos> Right. I might want to see if we can push those changes out of the httpapi plugin so it can be shared in module_utils
16:35:28 <mikewiebe> Makes sense.  If you have some specifics for how you want to do that please add that to the PR
16:38:26 <Qalthos> I'll have to think about it. It's been a while since I've looked at the (e|nx)api plugins
16:38:31 <ankitb_07> @Qalthos, Regarding module "[ansible/ansible#51238](https://github.com/ansible/ansible/pull/51238)". I applied the full path in the patch. Module build was successful. Ty for the fix. Please review and merge. Thanks.
16:39:12 <Qalthos> #chair nilashishc
16:39:12 <zodbot> Current chairs: Qalthos ganeshrn ikhan justjais nilashishc pabelanger privateip trishnag
16:40:03 <Qalthos> #topic Open Floor
16:40:18 <Qalthos> Anyone have anything else, or did I miss anyone?
16:45:15 <Qalthos> Okay, have a good week everyone. Thanks for coming!
16:45:19 <Qalthos> #endmeeting