16:00:37 <Qalthos> #startmeeting Ansible Network Working Group
16:00:37 <zodbot> Meeting started Wed Dec 19 16:00:37 2018 UTC.
16:00:37 <zodbot> This meeting is logged and archived in a public location.
16:00:37 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:37 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:00:37 <zodbot> The meeting name has been set to 'ansible_network_working_group'
16:00:52 <Qalthos> #topic Core Updates
16:01:42 <Qalthos> This week is not a release week for roles, so not a lot going on there today
16:02:20 <Qalthos> That said,
16:02:23 <Qalthos> #info Ported vyos provider load & replace to use cli_command and cli_config
16:02:46 <Qalthos> #info Working on vyos_ping module
16:03:32 <Federico87_> Hello, I have completed the ios_ntp module
16:03:33 <Federico87_> https://github.com/ansible/ansible/pull/49894
16:03:37 <Qalthos> #info Ansible 2.7.5 was released last Thursday
16:03:58 <Federico87_> if someone can have a look so we can merge (?)
16:04:26 <Qalthos> #link https://github.com/ansible/community/labels/network is where the agenda can be found as usual
16:04:45 <Qalthos> #topic Lenovo PRs
16:04:53 <Anil_Lenovo> Yes
16:05:21 <Qalthos> Anil_Lenovo: I saw cnos_interface earlier, I haven't looked at the other one
16:05:39 <Anil_Lenovo> Thats just got added
16:05:55 <Anil_Lenovo> i completed few minutes back only
16:06:04 <Anil_Lenovo> You may skip it for later
16:06:37 <Qalthos> Yeah, they look good, have decent tests, but I'll give it a more thorough read some time later today
16:06:49 <Anil_Lenovo> sure, as u please
16:07:20 <Qalthos> Anil_Lenovo: 👍
16:07:36 <Qalthos> #topic new ios NTP module
16:07:59 <Qalthos> Federico87_: I am assuming this is yours
16:08:16 <Federico87_> Ok, I believe is my turn. Sorry gusy, I am fairly new for in this thinghs :D
16:08:46 <Qalthos> So the biggest thing I see immediately is that there are no  tests
16:08:47 <Federico87_> I have raised a PR for that. All checks are passed. I have also provided some validation test
16:08:54 <Federico87_> not sure what the next tep will be
16:09:14 <Federico87_> ah ok..., so how this test have to be submitted?
16:10:29 <Qalthos> So, (simply because it's handy) at the end of the cnos_banner PR (https://github.com/ansible/ansible/pull/50145/files) you can see new files added to test/units/modules/network/
16:11:49 <Qalthos> You would want to add unit tests there under test/units/modules/network/ios and integration tests to test/integration/targets/ios_ntp
16:11:56 <Federico87_> ok, I ll have a look and trying to figure it out. Thanks for that
16:12:44 <Qalthos> the tests for nxos_ntp might be a good starting place if the modules are similar enough
16:13:22 <Qalthos> #action Federico87_ add tests to ios_ntp PR
16:13:36 <Federico87_> sure, thanks!
16:14:11 <Federico87_> I won't be availble untill 6th Jan thouhg, so I ll be able to have a look once back
16:14:40 <Qalthos> Well neither will I
16:14:46 <Qalthos> Oh, and speaking of which
16:14:57 <Qalthos> #topic Core Updates pt. 2
16:15:44 <Qalthos> #info This will be the last network IRC meeting of the year.
16:16:02 <Qalthos> Probably the next one will be the... second?
16:16:08 * Qalthos consults a calendar
16:16:46 <Qalthos> Yes, the second of January is likely the next IRC meeting, though I won't be the one running it
16:17:45 <Qalthos> #topic Open Floor
16:18:29 <Qalthos> Now that I've remembered to say that, does anyone have anything else to bring up?
16:18:44 <Anil_Lenovo> Happy Christmas !! and Wish u all a wonderful New Year !!
16:19:05 <Federico87_> Happy Christmas and Happy new year guys!
16:23:28 <Qalthos> Right, if there's nothing else, I'm going to close this especially early
16:23:48 <Qalthos> Have a good end of the year, everyone
16:23:55 <Anil_Lenovo> sure
16:24:02 <Anil_Lenovo> bye
16:24:04 <Qalthos> And thank you, as always, for showing up
16:24:17 <Qalthos> #endmeeting