Docs for how to add integration tests need
work(gundalow,
15:19:27)
https://raw.githubusercontent.com/ansible/community/master/meetings/ical/testing.ics
<- Testing Working Group meeting agenda(gundalow,
15:20:05)
ACTION: nitzmahone
give gundalow docs on how to pip install from a branch (which also
rebases)(gundalow,
15:25:09)
ACTION: gundalow to
review and write docs from
https://github.com/jctanner/ansible-tools/blob/master/ansible-pr-checkout(gundalow,
15:26:09)
document a testing workflow based around:
https://help.github.com/articles/checking-out-pull-requests-locally/(abadger1999,
15:28:22)
Bot could add a single comment on PRs saying
"Docs for PR author (thanks, how to add tests) PR authors (How to
download and test, how to report issues)(gundalow,
15:30:41)
ACTION: gundalow
document the magic metadata stuff(willthames,
15:33:04)
ACTION: gundalow
Document CI test aliases(sdoran,
15:34:34)
ACTION: gundalow to
talk mattclay to de duplicate Ansibullbot comments - especially for
same test failing on different Python versions -PR 46344(gundalow,
15:36:37)
ACTION: gundalow
runme.sh docs - If you are reading this you probs don't want
this(gundalow,
15:39:20)
Question: Should people with Commit powers
update PR for someone else(gundalow,
15:48:34)
Question: If a PR only needs a simple fix
before merge should that be fixed then merged(gundalow,
15:51:58)
Add more into Sanity tests for these
things(gundalow,
15:52:13)
If it's a PR older than n-months then asking
them the author to update isn't good(gundalow,
15:54:04)
Can we automate `version_added`(gundalow,
15:54:28)
jlk: I do think Ansible should take the
approach other projects have taken. "Your submission is great and it
is nearly complete. Thank you, we'll fix up the rest and merge it."
Focus on getting the code in rather than doing back/forth to have
the contributor have a "perfect" contributio(gundalow,
15:56:36)
Should we add commits to PRs that we will not
merge - Things are lost by force push?(gundalow,
15:59:36)
First PR comment for new_contributors, give
them some extra guidance, extra thanks. Make it clearer to reviews
that this is a new contributor and may need guidance,
https://developer.github.com/changes/2018-03-21-hovercard-api-preview/(gundalow,
16:03:25)