#ansible-meeting: Testing Working Group

Meeting summary

1. 1. Agenda https://github.com/ansible/community/labels/testing (gundalow, 17:01:01)
   
   
2. Clarification & next steps for unit tests (gundalow, 17:02:10)
   1. AGREED: new unit tests should be written to use pytest (gundalow, 17:02:48)
   2. high-value porting to pytest 1) it's useful to be able to override things from the CLI. Looks like for the option flags, that is by design.. (gundalow, 17:03:24)
   3. high-value porting to pytest: (1) grep -ri nose test/units (gundalow, 17:03:44)
   4. high-value porting to pytest: (1) grep -r procenv test/units (gundalow, 17:03:56)
   5. (1) lets us drop the nose dependency (gundalow, 17:04:06)
   6. lets us get rid of some of our code that pytest has good builtin support for (gundalow, 17:04:21)
   7. https://github.com/ansible/ansible/pull/33387/files#diff-7d19c1624d0977d32233184491b27e1bL118 (oldway) (Pilou, 17:11:02)
   8. https://github.com/ansible/ansible/pull/33387/files#diff-7d19c1624d0977d32233184491b27e1bL118 (old way) (Pilou, 17:11:26)
   9. https://github.com/ansible/ansible/pull/33387/files#diff-7d19c1624d0977d32233184491b27e1bR145 (new way) (Pilou, 17:11:32)
   10. ACTION: gundalow work with abadger1999 to reference good tests from dev_guide/testing_units.html (gundalow, 17:17:05)
   11. ACTION: gundalow work with abadger1999 to remove unittest references from dev_guide/testing_units.html (gundalow, 17:17:13)
   12. ACTION: gundalow work with abadger1999 to add links to mock & pytest to dev_guide/testing_units.html (gundalow, 17:17:27)
   
   
3. Unit test imports (gundalow, 17:20:38)
   1. https://github.com/ansible/ansible/issues/33302 Unit tests failed without ncclient installed (gundalow, 17:21:11)
   2. ACTION: gundalow to document how to skiptest pytest.skip ( https://docs.pytest.org/en/latest/skipping.html ) (though should be added to test/runner/requirements/units.txt) (gundalow, 17:25:21)
   3. https://docs.pytest.org/en/latest/skipping.html#skipping-on-a-missing-import-dependency (abadger1999, 17:32:34)
   4. https://github.com/ansible/ansible/blob/devel/test/units/modules/network/f5/test_bigip_device_trust.py#L22-L42 (gundalow, 17:39:11)
   
   
4. Open Floor (gundalow, 17:40:48)
   1. https://www.irccloud.com/pastebin/eXiPeenY/ (sdoran, 17:43:22)

Action items

1. gundalow work with abadger1999 to reference good tests from dev_guide/testing_units.html
2. gundalow work with abadger1999 to remove unittest references from dev_guide/testing_units.html
3. gundalow work with abadger1999 to add links to mock & pytest to dev_guide/testing_units.html
4. gundalow to document how to skiptest pytest.skip ( https://docs.pytest.org/en/latest/skipping.html ) (though should be added to test/runner/requirements/units.txt)

Action items, by person

1. abadger1999
   1. gundalow work with abadger1999 to reference good tests from dev_guide/testing_units.html
   2. gundalow work with abadger1999 to remove unittest references from dev_guide/testing_units.html
   3. gundalow work with abadger1999 to add links to mock & pytest to dev_guide/testing_units.html
2. gundalow
   1. gundalow work with abadger1999 to reference good tests from dev_guide/testing_units.html
   2. gundalow work with abadger1999 to remove unittest references from dev_guide/testing_units.html
   3. gundalow work with abadger1999 to add links to mock & pytest to dev_guide/testing_units.html
   4. gundalow to document how to skiptest pytest.skip ( https://docs.pytest.org/en/latest/skipping.html ) (though should be added to test/runner/requirements/units.txt)

People present (lines said)

1. gundalow (58)
2. abadger1999 (25)
3. mattclay (17)
4. sdoran (16)
5. zodbot (9)
6. ryansb (8)
7. Pilou (6)
8. rcarrillocruz (2)
9. resmo (1)
10. maxamillion (1)
11. bcoca (0)