09:02:42 <gundalow> #startmeeting Contributors Summit Hackathon
09:02:42 <zodbot> Meeting started Mon Mar 30 09:02:42 2020 UTC.
09:02:42 <zodbot> This meeting is logged and archived in a public location.
09:02:42 <zodbot> The chair is gundalow. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:02:42 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
09:02:42 <zodbot> The meeting name has been set to 'contributors_summit_hackathon'
09:02:53 <felixfontein> yay \o/
09:03:05 <gundalow> #chair cybette phips felixfontein resmo dmellado
09:03:05 <zodbot> Current chairs: cybette dmellado felixfontein gundalow phips resmo
09:03:17 <gundalow> I'm be bouncing online/offline  a bit this morning
09:03:40 <gundalow> Feel free to `#action We should do foo` for anything that we need to update in docs, examples, CI, etc, etc
09:04:24 <felixfontein> gundalow: do you mind if I merge #66?
09:04:46 <dmellado> felixfontein: mind putting the whole link?
09:04:59 <dmellado> folks, I'm feeling a bit unwell today, but will be around to help if needed ;)
09:05:26 <felixfontein> dmellado: https://github.com/ansible-collections/community.general/pull/66
09:06:00 <gundalow> felixfontein: merge at will
09:06:28 <shaps> Morning all
09:06:33 <sshnaidm> hi all
09:06:40 <felixfontein> gundalow: will do, thanks!
09:07:33 <gundalow> #action gundalow add `settings.yml` to all Community repos
09:07:35 <gundalow> hey shaps
09:07:38 <gundalow> and everybod else
09:08:06 <felixfontein> hi sshnaidm!
09:08:31 <sshnaidm> gundalow, what is settings.yml?
09:13:45 <shaps> I'm going to refactor all the github modules today! \o/
09:16:29 <felixfontein> cool!
09:16:48 <cybette> \o/
09:16:50 <cybette> morning
09:17:03 <tadeboro> sshnaidm: Another sausage making detail I guess ;) But I am also interested in learningabout it.
09:30:21 <belfast77> morning
09:32:25 <dmellado> morning cybette
09:35:47 <shaps> when importing from module_utils now, should I do ..module_utils or ansible.collections.community.general.module_utils ?
09:40:57 <felixfontein> ok, I'm fully around now!
09:41:13 <felixfontein> shaps: I'm not sure whether the relative import will work with Ansible 2.9
09:41:55 <shaps> right, so I'll just stick with the full path, that works fine on 2.9 right?
09:42:29 <felixfontein> I think so. maybe relative imports also work in 2.9, I haven't tested that
09:46:43 <resmo> I would like to not use full path. I wonder if e.g. doc_fragments would work with relative path
09:46:50 <felixfontein> hmm, every PR in community.general with a changelog fragment will trigger a *full* CI run. that's really annoying.
09:47:16 <felixfontein> resmo: I don't think doc fragments will work with relative paths, since that's not a Python import
09:48:20 <resmo> felixfontein: yes I know, but haven't tested it yet.
09:51:42 <resmo> what bother me is, collections are not easy to "fork" (e.g. to implement a quick fix unless the fix is in upstream collection). as a result, there might be many collections for the same purpose because they can't be merged back. I hope not but that is my concern.
09:52:52 <felixfontein> I know what you mean
09:52:56 <gwmngilfen> Morning all
09:53:05 <felixfontein> morning gwmngilfen!
09:53:17 <resmo> o/ gwmngilfen
09:59:50 <shaps> hi gwmngilfen
09:59:50 <dmellado> also, regarding collections, there's a thing that you might need to consider, which is its requirements
09:59:58 <dmellado> besides the reqs con collections
10:00:33 <dmellado> we're thinking about how to handle reqs when a collection required x>=1 but another dependant would need x<1 and such ;)
10:00:46 <dmellado> basically we were thinking about using a global constraints file
10:00:59 <dmellado> but there are still so much stuff to consider
10:01:25 <felixfontein> andersson007_: can we merge https://github.com/ansible-collections/community.general/pull/58 ?
10:01:51 <felixfontein> dmellado: best strategy: don't have reqs ;)
10:03:04 <gwmngilfen> So what have I missed? General hacking, or are we gathering on topics?
10:03:23 <felixfontein> gwmngilfen: I think right now everyone has their own topics
10:04:01 <shaps> yeah, mostly general hacking
10:04:15 <andersson007_> felixfontein: i'd better wait for bmalynovych a couple of days, he's a WG leader
10:04:24 <gundalow> #action every PR in community.general with a changelog fragment will trigger a *full* CI run. that's really annoying.
10:04:44 <gwmngilfen> Super. Well if anyone wants to work on data things let me know :)
10:04:47 <felixfontein> andersson007_: ok, then I'll add a changelogs/ directory manually
10:05:01 <andersson007_> ok
10:05:11 <felixfontein> gundalow: I prepared https://github.com/ansible/ansible/pull/68550 and https://github.com/ansible-collections/community.general/pull/71 so that we can turn that off temporarily :)
10:05:30 <gundalow> dmellado: https://github.com/ansible-collections/grafana/blob/master/.github/settings.yml is configuration for https://github.com/probot/settings to enforce various GitHub settings such as branch protections
10:05:36 <gundalow> sshnaidm https://github.com/ansible-collections/grafana/blob/master/.github/settings.yml is configuration for https://github.com/probot/settings to enforce various GitHub settings such as branch protections
10:05:46 <gundalow> sorry, forgot who asked, ignore that dmellado
10:06:17 <gundalow> resmo: would you be able to expand on "what bother me is, collections are not easy to "fork" (e.g. to implement a quick fix unless the fix is in upstream collection)."
10:07:13 <gundalow> #chair dmellado andersson007_ gwmngilfen shaps resmo
10:07:13 <zodbot> Current chairs: andersson007_ cybette dmellado felixfontein gundalow gwmngilfen phips resmo shaps
10:07:14 <dmellado> felixfontein: lol, I wish I would be able to do that xD
10:07:17 <dmellado> no worries gundalow
10:08:36 <felixfontein> gundalow: mind if I merge https://github.com/ansible-collections/community.general/pull/71 if tests pass, and then start telling people to add changelog fragments to their PRs?
10:08:48 <shaps> is there a way I can run sanity/integration locally without having to have community.general in ansible_collections/community/general?
10:09:01 <gundalow> felixfontein: haha, was just looking for a PR that triggeres changelogs, and I see you have a likely fix in https://github.com/felixfontein/ansible/commit/2b540f4be436195f4aa1e7283c20582f6fcb7201
10:09:05 <shaps> also, not sure where that ansible_collections/ should be in the first place?
10:10:23 <gundalow> shaps: I have community.general checked out into `~/git/work/ansible_collections/community/general`
10:10:25 <felixfontein> shaps: not that I know. it should probably be in a path where ANSIBLE_COLLECTIONS_PATHS points to
10:10:58 <felixfontein> gundalow: it is a minimal fix ;) but it should work for changelog fragments
10:11:00 <gundalow> `ansible_collections/community/general` is so ansible-test knows what to do
10:11:48 <gundalow> felixfontein: yup, feel free to merge #71 if CI looks good
10:12:17 <gundalow> mattclay: is https://github.com/felixfontein/ansible/commit/2b540f4be436195f4aa1e7283c20582f6fcb7201 the right fix so changelogs don't trigger a full CI run?
10:12:41 <gundalow> #action revert https://github.com/ansible-collections/community.general/pull/71 once changelog detection has been fixed
10:12:51 <felixfontein> I'll test it once that's merged, by creating a PR which adds changelogs/fragments/.empty :)
10:12:59 <gundalow> mattclay: correction, PR is https://github.com/ansible/ansible/pull/68550
10:13:58 <andersson007_> all discussions about collection development are only in this channel (not in devel)?
10:14:33 <felixfontein> andersson007_: in general no, but right now it's easier to ask here I guess
10:14:38 <shaps> gundalow: yeah, my OCD kicks in for that ansible_collections directory heh
10:15:11 <shaps> But I guess I’ll just have to do what ansible-test tells me to
10:15:27 <felixfontein> shaps: ansible itself needs that as well
10:15:45 <felixfontein> (which I guess is the main reason why ansible-test enforces it, since it internally uses ansible code all over the place)
10:16:28 <shaps> So every ANSIBLE_COLLECTIONS_PATH has to have ansible_collections as “top level dir”?
10:17:06 <felixfontein> I think so
10:17:08 <cyberpear> yuck, none of the other *_PATH's work like that, do they?
10:17:17 <shaps> No
10:17:23 <felixfontein> shaps: also it is PATHS with a trailing S
10:17:29 <cyberpear> nor ANSIBLE_LIBRARY
10:17:43 * cyberpear still needs to open a PR to alias the signular PATH
10:17:45 <shaps> felixfontein: yes typo
10:17:57 <felixfontein> cyberpear: please do that :)
10:18:03 <felixfontein> shaps: just wanted to make sure you use the right variable :)
10:18:15 <webknjaz> @shaps: yes, `ansible_collections` is mandatory
10:18:48 <shaps> Yep, I guess it’s because of the “ansible_collections.” namespace
10:19:21 <webknjaz> yes
10:19:47 <webknjaz> this is how the collections loader works
10:21:30 <shaps> cool, thanks
10:22:16 <gwmngilfen> i'm going to spend a bit of time tweaking the Contributor Summit survey from Atlanta for all the lovely participants yesterday - if anyone would like to suggest questions that should be on there, fire away :)
10:22:59 <resmo> cybette: is the recording already available somewhere?
10:25:38 <zbr> regarding changelogs was a decision already made to use fragments?
10:26:25 <gundalow> gwmngilfen: Excellent. I wonder if it would be worth asking more questions around the virtual side (did the video work for you. Would you like like captioning). Did you use Video and IRC. Is English your second language (maybe useful to help weight the understaning/ability to flow)
10:26:49 <resmo> zbr: AFAIK still in RFC
10:26:51 <zbr> i am asking because I find it as a PITA, especially for occasional contributors, many of them will forget to bother to add the fragment, and the PR will endup not being merged..
10:27:26 <felixfontein> there will be reminders
10:27:35 <felixfontein> also it is a PITA when there is no changelog
10:28:16 <zbr> if you do 2-3+ contribs per week it is no longer an issue, as it becaomes a habit. but for others is not like that and lowers the success rate (merge).
10:28:49 <felixfontein> do you have a better alternative? (and no, using the git commit history is not an alternative.)
10:29:06 <zbr> I am not proposing no-change log either.
10:29:34 <gwmngilfen> gundalow for sure, we need to strip out all physical attendance stuff. Tooling questions make sense. Will prototype something shortly
10:29:38 <zbr> felixfontein: read about https://github.com/release-drafter/release-drafter and how it works.
10:29:57 <zbr> i agree that git-changelog is not user-friendly, sometimes is not even developer friendly.
10:30:02 <gwmngilfen> (Although my laptop just froze, yay)
10:30:13 <zbr> release notes != git changelog, we all know that.
10:30:14 <felixfontein> zbr: that tool uses git history, right?
10:30:28 <resmo> zbr: nice hint
10:30:29 <zbr> we do not want "attempt 666 to fix ci"
10:30:39 <gundalow> acozine: samccann FYI we are talking about changelogs
10:31:06 <gundalow> resmo: videos are being processed, we will ping here once they are on YouTube
10:31:14 <resmo> gundalow: cool
10:31:14 <felixfontein> I think right now we're repeating the same discussion as last time
10:33:51 <andersson007_> what are the options about changelogs?
10:34:10 <felixfontein> gundalow: is it possible to turn it off that shippable does a full (?) CI run after every PR merged?
10:34:11 <resmo> zbr: IMHO changelog fragments would be recommended to get embedded in ACD changelogs but the collection can make any form of changelog (e.g. openstack uses reno release notes) as long it is linkable.
10:34:27 <gundalow> andersson007_: Afternoon. See https://github.com/ansible-collections/overview/issues/18 for a summary of where we are upto
10:34:43 <gundalow> felixfontein: hum, is that because we are burning CI capacity?
10:34:48 * gundalow looks at Shippable config
10:34:52 <andersson007_> gundalow: afternoon, thanks
10:35:01 <felixfontein> resmo: zbr: collections can also use their git history if they want. but it's not an option for community.general.
10:35:28 <felixfontein> gundalow: it is blocking tests for other PRs for quite some time
10:35:45 * resmo -> lunch
10:35:50 <felixfontein> resmo: en guete!
10:36:08 <resmo> felixfontein: äbeso ;)
10:36:14 <felixfontein> resmo: merci!
10:36:56 <felixfontein> andersson007_: https://github.com/ansible-collections/overview/issues/18
10:37:04 <felixfontein> oh
10:37:09 <felixfontein> I just see gundalow was quicker :)
10:37:19 <andersson007_> felixfontein: yep, thanks!
10:37:34 <gundalow> felixfontein: lets see if https://github.com/ansible-collections/community.general/pull/73 works
10:38:11 <felixfontein> gundalow: can we just merge it? otherwise we'll only find out in one hour or so ;)
10:38:47 <Federico87_> I ll drop mine too :)  https://github.com/ansible-collections/community.general/pull/57 felixfontein is looking already in some errors but I have a sanity issue related to symlink for ansible-doc. Not sure how to fix that though. :(
10:39:48 <gundalow> felixfontein: Do you have powers to see https://app.shippable.com/github/ansible-collections/community.general/dashboard I don't see a new run on `master` so I *think* that worked
10:39:55 <felixfontein> gundalow: looks like it works, at least shippable didn't start another build for master
10:40:11 * gundalow kills the existing `master` CI runs
10:40:12 <felixfontein> gundalow: I have, also one more level up (which is also very useful)
10:41:29 <felixfontein> gundalow: for some reason, CI for https://github.com/ansible-collections/community.general/pull/72 was also shown as master
10:42:04 <gundalow> felixfontein: hum, not sure what Shippable does with PRs in flight
10:42:24 <felixfontein> it might be that the branch it shows is the branch where the PR is supposed to be merged into
10:42:48 <felixfontein> did you just caccel it again?
10:42:51 <felixfontein> *cancel
10:43:13 <gundalow> yup, I emptied out https://app.shippable.com/github/ansible-collections/community.general/dashboard then closed/opened your PR
10:43:23 <felixfontein> ah, the close probably cancelled my rerun
10:43:47 <felixfontein> close/reopen CI tigger was done by ansibot IIRC, so I have to restart it manually
10:43:58 <felixfontein> or did you just do it?
10:44:05 <gundalow> I just did it
10:44:13 <felixfontein> ok :)
10:44:31 <felixfontein> it should be a short run anyway, if https://github.com/ansible/ansible/pull/68550 works
10:44:35 <misc> now, I realized that we never seen ansibot and gundalow in the same room, maybe ansibot is gundalow secret identity
10:44:43 <gundalow> hum, and I'm still seeing `context: master`, so I don't know anymore
10:45:09 <felixfontein> misc: good theory! :D
10:45:22 <felixfontein> gundalow: I guess context is the brancht he PR is supposed to be merged into, then
10:45:42 <gundalow> misc: I liked this tweet from jpmens yesterday https://twitter.com/jpmens/status/1244252849774759937?s=19
10:46:03 <felixfontein> gundalow: looks like it is working! \o/
10:46:42 <gundalow> misc: though technically jtanner is the voice of ansibulbot
10:47:58 <felixfontein> gundalow: the PR's CI went through in 3 minutes!
10:48:32 <gundalow> \o/
10:48:36 <gundalow> nice work felixfontein
10:49:12 <felixfontein> I'll merge that PR, mention changelog fragments in the other PRs, and then after lunch I'll add changelog fragments for the already merged PRs (when necessary) and look at Federico87_'s PR
10:49:28 <felixfontein> (if someone wants to look at why tests fail for Federico87_'s PR before that, feel free!)
10:59:58 <gundalow> acozine: samccann FYI for community.general we are asking people to add `changelogs/fragments` (following Ansible's standard), this is so we can merge PRs. If we decide in the future to change the format we can rewrite those files
11:00:59 * gundalow -> lunch
11:05:05 * felixfontein -> lunch
11:08:49 <cybette> resmo not yet, hope to get them up today/tomorrow
11:10:10 <jhawkesworth> heya.  If I could get a ping when recordings are available I'd like to listen in - missed way too much of yesterday in the end :-(
11:32:00 <cybette> jhawkesworth: I'll be uploading them to this channel so you can subscribe to it: https://www.youtube.com/channel/UCThD8eHpOt7YdJlzpQRiAvQ
11:32:48 <jhawkesworth> Thank you cybette
11:33:37 <cybette> #info Contributor Summit recordings will be uploaded to https://www.youtube.com/channel/UCThD8eHpOt7YdJlzpQRiAvQ
11:34:01 <cybette> jhawkesworth: btw have you filled in this attendee survey https://forms.gle/Uv9Zdaz7aTAAwtsQ8
11:41:21 <jhawkesworth> I have now cybette although I doubt I qualify as 'attending' as it turned out. I do appreciate the work that you folks  have put in to make this happen though. Thank you all
11:47:45 <cybette> jhawkesworth: every bit counts :) we also realise that Sunday may not work for everyone. going forward we plan to have more virtual contributor sessions like this accommodating to different time zones and days.
11:47:47 * felixfontein is back
11:47:59 * shaps food
11:48:31 <fobhep> <cybette "jhawkesworth: I'll be uploading "> +q
11:48:37 <fobhep> > <@cybette:matrix.org> jhawkesworth: I'll be uploading them to this channel so you can subscribe to it: https://www.youtube.com/channel/UCThD8eHpOt7YdJlzpQRiAvQ
11:48:37 <fobhep> * +1
11:50:35 * gwmngilfen food and childcare, back in a few hours
12:00:42 <gundalow> jhawkesworth: you very much do count :)
12:17:50 <lillianphyoe> anybody please let me know how can I join to hackthon? is it over? I am sorry for late.
12:21:28 <resmo> gundalow: AFAIK there are 3 kinds of collections: supported, partner and community. Is there a way to find out what kind of collection it is?
12:21:45 <resmo> on galaxy?
12:23:31 <felixfontein> lillianphyoe: the hackathon is still going on! right now, there's no specific procedure for anything, feel free to work on anything you're interested in
12:25:21 <felixfontein> Federico87_: sorry for CI, that wasn't intended
12:25:40 <Federico87_> np, is running now :)
12:25:56 <felixfontein> Federico87_: ah, great :)
12:26:37 <lillianphyoe> felixfontein thank you. have to submit ansible roles which I want to contribute on ansible galaxy ?
12:31:03 <felixfontein> Federico87_: sanity tests now pass! \o/
12:31:46 <felixfontein> lillianphyoe: I didn't understood your question. are you asking where to submit such roles on galaxy?
12:32:18 <lillianphyoe> yes that is!
12:32:48 <Federico87_> integration failed due to a too early sunday morning code change. On it now :D
12:33:29 <felixfontein> lillianphyoe: hmm maybe someone here knows more about that? I only did that once and that was a longer time ago
12:33:46 <felixfontein> Federico87_: isn't it Monday?
12:34:10 <Federico87_> correct, but I changed the code yesterday ;)
12:35:31 <felixfontein> lillianphyoe: did you look at https://galaxy.ansible.com/docs/contributing/index.html , in particular https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/docs/contributing/importing.html ?
12:42:37 <Federico87_> Integration passed locally...let's see what happens on git
12:57:23 <Federico87_> I got these errors for integration:
12:57:30 <Federico87_> OPENSUSE: Could not find a module for zypper
12:57:59 <Federico87_> FREEBSD: Could not find a module for pkgng
12:58:01 <felixfontein> on CI?
12:58:05 <Federico87_> yes
12:58:18 <felixfontein> let me take a look
12:58:36 <Federico87_> Can't run on local as I get some container error when I try to run integration on local
12:58:40 <felixfontein> ah
12:58:49 <felixfontein> you didn't include the requirement in meta :)
12:59:28 <felixfontein> I added a suggestion
12:59:30 <Federico87_> I reverse eng from other test so most probably yes :)
12:59:35 <felixfontein> that is needed until ansible/ansible can do routing
13:00:05 <felixfontein> (i.e. until https://github.com/ansible/ansible/pull/67684 is merged)
13:00:18 <felixfontein> that will happen soon, and until then we need this hack :)
13:00:21 <Federico87_> ok. do you have a specific container version for local freebsd and opensuse?
13:00:35 <felixfontein> no, it is not related to the container version
13:01:06 <felixfontein> the problem is that zypper and pkgng are now in community.general, and no longer in ansible/ansible itself, but the package installer detection doesn't know that yet (and so `package` tries to load them from ansible/ansible)
13:01:53 <Federico87_> so is that the reason why I get this erro when I try to run locally
13:02:01 <Federico87_> ERROR: Command "docker exec -i 62033a12a7d3499cb90c68ad6aead57584f4d1a0798447cba6ec9bd5fc449c75 dd of=/root/docker.sh bs=65536" returned exit status 1.>>> Standard ErrorError response from daemon: Container 62033a12a7d3499cb90c68ad6aead57584f4d1a0798447cba6ec9bd5fc449c75 is not running
13:02:10 <Federico87_> ?
13:02:28 <felixfontein> no, that's unrelated I think
13:08:42 <resmo> felixfontein: investigating failing tests for cloudstack
13:09:34 <felixfontein> resmo: thanks!
13:09:56 <Federico87_> felixfontein ERROR! the role 'setup_pkg_mgr' was not found
13:10:45 <Federico87_> can't find that role anywhere under community.general
13:10:56 <felixfontein> Federico87_: if you have that locally, you probably need to rebase so you get changes after you branched your branch
13:11:02 <felixfontein> on CI it ran through
13:14:52 <Federico87_> All checks passed \0/
13:15:08 <felixfontein> great :)
13:15:12 <Federico87_> Thanks for your time.
13:15:23 <Federico87_> When potentially would be merged?
13:19:02 <felixfontein> Federico87_: let me do some reviewing
13:19:58 <Federico87_> thanks
13:24:35 <gundalow> hum, not sure what heppened then. What messages did I miss?
13:25:29 <misc> 15:19:25|  felixfontein> Federico87_: let me do some reviewing
13:25:30 <misc> 15:20:21|  Federico87_> thanks
13:25:41 <misc> (that's it)
13:26:35 <gundalow> misc: Thanks :)
13:30:43 <felixfontein> gundalow: https://github.com/ansible-collections/community.general/pull/76
13:30:58 <felixfontein> should I create a similar PR for f5?
13:33:37 <gundalow> felixfontein: if you could that would be great
13:33:56 <felixfontein> ok, will do!
14:48:28 <gundalow> shaps: how's github looking?
15:01:07 * gundalow starts removing network stuff from community.general
15:06:03 <felixfontein> \o/
15:06:11 <felixfontein> then I won't touch f5 for now (since that's network)
15:09:08 <gundalow> felixfontein: yup, thanks
15:11:58 <gwmngilfen> @gundal
15:11:58 <gwmngilfen> fail
15:11:58 <gwmngilfen> gundalow:  where's it going? we should add those repos to the contributor metrics
15:18:38 * geerlingguy "gundal" sounds like a character in an old western
15:29:40 <samccann> gundal... with his 10gal had and six shooter hangin off a hip...
15:30:50 <shaps> gundalow: not too bad, got to finish updating the webhooks module and get some tests written up
15:37:29 <sshnaidm> can someone review please CI patch for ansible podman collection? https://github.com/containers/ansible-podman-collections/pull/15
15:37:41 <sshnaidm> used a generated one as a base
15:40:03 <geerlingguy> sshnaidm: quick question—any reason why all the `run` commands are separated line per arg? e.g. https://github.com/containers/ansible-podman-collections/pull/15/files#diff-ef213732f0f3ba7e84c4fdc772bc2e38R99-R104
15:40:27 <geerlingguy> Seems like something like that reads better (and keeps file more compact) if written like `python -m pip install --user ${{ matrix.ansible-version }} virtualenv` instead
15:40:47 <sshnaidm> geerlingguy, well, no idea, it was generated like that by migrate tool, I think it tried to keep line shorter(?)
15:41:10 <sshnaidm> geerlingguy, yeah, agree
15:41:41 <geerlingguy> heh especially like this https://github.com/containers/ansible-podman-collections/pull/15/files#diff-ef213732f0f3ba7e84c4fdc772bc2e38R108-R109
15:43:12 <geerlingguy> other than that, seems correct. Maybe a few more test scenarios in the matrix than I would necessarily care about (just because that means test runs will take a long time)
15:50:08 <sshnaidm> geerlingguy, yeah, next step is reduce it.. the first version included in 3 times more I think :))
15:50:44 <resmo> hmm could we increase the number of processing jobs for community.general a bit?
15:51:15 <sshnaidm> is this gh workflow totally free for opensource? or there are some limits
15:52:04 <gundalow> sshnaidm: yes and maybe, though will be cheaper than shippable
15:52:40 <gundalow> sshnaidm: correction yes free. No limits
15:52:50 <sshnaidm> gundalow, nice
15:53:15 <gundalow> GitHub actions with private repos cost
15:57:09 <shaps> you still have something like 2k hours (or units?) free for private repos
16:07:38 <sshnaidm> 2,000 Action minutes/month for public repo https://github.com/pricing
16:09:44 <sshnaidm> and then ci turns into pumpkin..
16:11:18 <geerlingguy> community.general will eat up those minutes quickly
16:13:31 <felixfontein> yep
16:13:47 <felixfontein> a day already has 1440 minutes
16:14:04 <felixfontein> and community.general has 100 CI nodes :)
16:22:21 <shaps> yeah, that's not going to last long is it? :D
16:22:46 <felixfontein> if you're really lucky, a day maybe? ;)
17:20:37 <gundalow> sshnaidm: geerlingguy felixfontein shaps So according to  https://github.com/organizations/ansible-collections/settings/billing (which you will not be able to see) it implies GitHub actions for free repos are unlimited
17:21:38 <gundalow> oh, I wonder  if `2,000 Free for public repositories` is badly worded. Free for public. 2,000 for private repos
17:21:40 <felixfontein> I wonder for which number of unlimited they start asking questions :)
17:21:49 <shaps> That was my understanding too. But the pricing page seems different to me
17:22:15 <gundalow> I exported the billing log, GitHub Actions are in there
17:22:45 <shaps> gundalow: yep that’s what I expected by looking at the billing settings (of some of my own repos)
17:22:58 <shaps> Do the actions also show a price or are they 0?
17:23:44 <gundalow> I think we are good
17:25:39 <Pilou> There is a Javascript error (ERROR TypeError: "n.infoData.apb_metadata.metadata is undefined") here: https://galaxy.ansible.com/ansible/django-template, is that expected ? The "progress circle" never disappear. The same error occurs with other roles.
17:25:56 <sshnaidm> gundalow, I suppose it should be same for https://github.com/containers/ansible-podman-collections ?
17:26:51 <sshnaidm> gundalow, but anyway we have cirrus ci and zuul as well, so should be fine too..
17:32:03 <geerlingguy> gundalow: heh, wait until we have like 10 runners going full bore 24x7, we'll see if a GitHub rep pings someone
17:33:02 <geerlingguy> I'm kind of amazed Travis CI's never throttled me back... every few weeks I push up changes that trigger 200+ builds (with 800+ individual environments) and I can actually make an impact on the graphs here :D https://www.traviscistatus.com/#system-metrics
17:33:26 <bcoca> geerlingguy: they used to throttle us tons, why we moved to shippable
17:33:33 <bcoca> at least one reason
17:52:05 <sshnaidm> felixfontein, would you like to look as well? https://github.com/containers/ansible-podman-collections/pull/15
17:57:19 <felixfontein> sshnaidm: looking
18:00:58 <felixfontein> sshnaidm: why do you run ansible-test unit and sanity twice, once in venv and once in docker container? isn't one of them enough?
18:02:02 <sshnaidm> felixfontein, well, I wonder if something can be different? tbh I can't think about something that will differ
18:02:26 <felixfontein> sshnaidm: for sanity tests, nothing should differ (if it does, it is probably a bug)
18:02:41 <felixfontein> sshnaidm: for unit tests, it should only depend on the Python version (or on requirements installed)
18:02:49 <sshnaidm> felixfontein, afaik what matters is only python version, yeah
18:03:37 <sshnaidm> felixfontein, so better to use containers only?
18:05:02 <felixfontein> sshnaidm: I'd stick to containers (resp. ansible-test's default container)
18:05:49 <felixfontein> also leaves more resources for integration testing :)
18:09:09 <felixfontein> also the default container provides a full list of ansible versions for unit tests (for sanity tests the version doesn't matter)
18:09:58 <sshnaidm> felixfontein, actually I found some differences in various ansible-test versions 2.9 and devel, but I'll use the latest
18:10:16 <sshnaidm> like different results for sanity tests
18:10:35 <mattclay> sshnaidm: Yes, there are new/different sanity tests in devel vs stable-2.9.
18:11:09 <sshnaidm> mattclay, ack, so choosing latest version is the best approach I suppose?
18:11:16 <felixfontein> yes, but that's not a difference in Python version or environment in which that version of ansible-test is run :)
18:12:02 <mattclay> sshnaidm: That depends what you're trying to do. If you have a collection that you want to work on Ansible 2.9 and the upcoming 2.10 (devel) you probably want to test against both -- but if you're short on test resources then test against devel for now.
18:14:51 <sshnaidm> mattclay, I see, so let's check both..
18:28:55 <geerlingguy> We're currently testing kubernetes collection just against devel—there are a few things that behave different in 2.9 so it's easier to not test there for now
18:29:10 <geerlingguy> (versus trying to maintain the config to test in both successfully)
18:33:27 <felixfontein> community.general is currently also only tested against devel; I guess we might also want to run some tests against 2.9 eventually, but right now getting tests against devel work has top priority :)
18:42:19 <gundalow> hum, that's a fair point
18:42:33 <gundalow> I hadn't really thought about 2.9 and collections
18:43:27 <geerlingguy> Well at least for now, community.general doesn't have additions/fixes that aren't in 2.9, so it's more of a moot point
18:43:39 <geerlingguy> there are already some people using the kubernetes collection with 2.9, so we might add tests for it at some point
18:44:12 <gundalow> geerlingguy: how do you know there are people using 2.9+kubernetes collection?
18:44:46 <geerlingguy> 2 things: https://galaxy.ansible.com/community/kubernetes shows 25,000 downloads (so far)
18:45:00 <geerlingguy> and the operator-sdk project is already using it instead of builtins
18:45:15 <jtanner> nice
18:45:19 <jtanner> yer a popular guy
18:45:25 <geerlingguy> hey it ain't me
18:45:33 <jtanner> well, you organized it
18:46:21 <geerlingguy> Well yeah, but I've only touched maybe 2% of the actual code :P — but it does do better when you have both good code and some organization!
18:53:30 <bcoca> a clear objective and a plan do wonders ...
18:59:34 <felixfontein> geerlingguy: there are already PRs for community.general which add new stuff (or maybe we already merged one? I'm not sure anymore)
19:06:33 <geerlingguy> eek! I'd hold off on that until it's stable / passing tests for everything (did we make it to that point yet?)
19:07:30 <felixfontein> tests are mostly stable
19:07:56 <felixfontein> there are still failures, but they don't hide anything serious anymore
19:08:16 <felixfontein> (one needs to look at what exactly is failing for sanity and units)
19:10:14 <bcoca> i would include 'ignored' tests in that
19:10:24 <bcoca> since many of those are cause of missing deps
19:11:00 <felixfontein> you mean skipped unit tests?
19:11:35 <felixfontein> I don't think they were running in ansible/ansible either, since the same requirements are around
19:13:09 <bcoca> requirements is other collections, not talking about librarires/utilitites
19:13:21 <felixfontein> all requirements are there
19:13:37 <bcoca> not for xfs
19:13:38 <felixfontein> except where the requirements are broken (f5 modules) resp non-existant (netapp modules)
19:13:46 <felixfontein> ah, right, that needs `mount`
19:13:47 <bcoca> they are actually commented out, all fo em, in galaxy.yml
19:13:58 <bcoca> felixfontein: one example, but many more
19:14:02 <felixfontein> CI installs them anyway
19:14:25 <felixfontein> tests/utils/shippable/shippable.sh is currently the "real" source of truth :)
19:15:35 * bcoca starts ddrinking to wipe that out from his memeory before it fixates
19:15:41 <felixfontein> also, I think almost all requirements are for testing, not for the modules/... themselves
19:15:44 <felixfontein> lol
19:15:56 <bcoca> for xfs, they are required at runtime
19:16:05 <felixfontein> there's too much in flux right now; I'm waiting for the network modules to vanish (which will kill most dependencies)
19:16:09 <bcoca> pretty sure the crypto and netcommon are also required at runtime
19:16:19 <geerlingguy> felixfontein: but those are moving into a network collection right?
19:16:27 <bcoca> same for google modules (since they use the common module_utils from the 'supported' ones)
19:16:32 <felixfontein> geerlingguy: I think so. gundalow is working on that AFAIK
19:16:43 <geerlingguy> (seems like a lot of networking ones are where there is more pain, especially for deeper testing)
19:17:08 <felixfontein> geerlingguy: indeed!
19:17:33 <bcoca> felixfontein: if collection was only needed for testing there would have been a requirements.yml in tests/ with that list
19:17:40 <bcoca> migration script accounted for that
19:17:59 <bcoca> https://github.com/ansible-collections/community.general/blob/master/tests/requirements.yml
19:18:01 <felixfontein> bcoca: there is, but currently ansible-test doesn't use it
19:18:03 <bcoca> ^ those are 'testing only'
19:18:09 <felixfontein> so shippable.sh has to install them manually
19:18:11 <bcoca> i know, but we were asked to create it
19:18:24 <bcoca> anything in galaxy.yml is RUNTIME
19:18:24 <felixfontein> eventually ansible-test will use them (I hope)
19:18:38 <bcoca> we generated the list, if people wish to ignore ....
19:19:18 <mattclay> felixfontein: Having ansible-test install collection dependencies is something I plan on working on. I just haven't had time to get to it yet.
19:19:40 <bcoca> file format in test/ might not be ideal though
19:19:53 <mattclay> Yeah, I don't know what the file format will be yet.
19:19:54 <bcoca> i would have made 'comments' vs sections on integration vs unit
19:20:05 <bcoca> https://github.com/ansible-collections/community.general/blob/master/tests/requirements.yml <= the one we already generated i mean
19:20:21 <bcoca> you should have required collections there already (at migration time .. once time passes ...)
19:20:34 <felixfontein> mattclay: no worries
19:21:22 <bcoca> mattclay: since we really had nothing to go on, that is what we ended up with, but feel free to set your own format(s) , this hopefully will make that task easier for these collections
19:21:57 <gundalow> felixfontein: bcoca geerlingguy plugins/modules/network/* (and related plugins) are moving out of community.general into (new) community.network collection. It's getting there
19:22:18 <geerlingguy> gundalow++
19:22:49 <bcoca> gundalow: still unrelated to the xfs issue .. but good!
19:23:07 <felixfontein> besides network dependencies, there are only three runtime dependencies: ansible.posix (one module), community.kubernetes (kubevirt modules), google.cloud (google modules)
19:23:35 <felixfontein> (the one module is aix_filesystem)
19:23:38 <gundalow> bcoca: oh, didn't see context
19:24:09 <bcoca> felixfontein: no, as i said, everything in galaxy is runtime dep
19:24:58 <felixfontein> bcoca: yes, but they are almost all for network modules, and they are moving out of the repo
19:25:00 <bcoca> most of them are cloud/networking modules that were ignored by vendors which took ownerhsip of others + module-utils common to both
19:25:08 <bcoca> netowrk, yes, but still also cloud
19:25:43 <bcoca> and still unrelated to my issue, which is ansible.posix related
19:25:56 <felixfontein> yes
20:02:49 <sshnaidm> so for installing from git it's enough to do like: git clone https://github.com/namespace/collection ~/.ansible/collections/ansible_collections/namespace/collection
20:02:56 <sshnaidm> right?
20:03:19 <bcoca> for most issues, yes
20:03:43 <bcoca> right now there are slight diffs between MANIFEST.json (installed package) and galaxy.yml (raw repo)
20:03:56 <bcoca> but should not impact runtime
20:04:26 <sshnaidm> great, thanks
07:18:39 <gundalow> Morning all
07:29:40 <felixfontein> how's removing the network modules going?
07:30:11 <felixfontein> also, should we merge https://github.com/ansible-collections/community.general/pull/76 ?
07:36:32 <gundalow> felixfontein: yup, I think so. I've approved the PR
07:37:29 <gundalow> #action we need ansible-test to validate meta/routing.yml in collections (do files exists)
07:38:42 <gundalow> #action validate-modules deprecation plugin test needs updating for collections to use meta/routing.yml to check if the file is deprecated.
07:40:20 <gundalow> mattclay: 1) what would be the right way for ansible-test to know if it should run extra tests against a collection vs ansible/ansible checkout? 2) what do you think could be the conditional to check for a collection in validate-modules?
07:41:23 <mattclay> gundalow: We already have a conditional in validate-modules to change tests based on whether or not a collection is being tested.
07:42:03 <felixfontein> gundalow: cool! I've pressed the big green button :)
07:42:42 <mattclay> gundalow: https://github.com/ansible/ansible/blob/2b4ca69bc249b27d853085125a6cb091fd11409e/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py#L2114
07:43:35 <gundalow> mattclay: ah excellent. Thanks
07:43:40 <andersson007_> morning all
07:43:51 <gundalow> Hi andersson007_ and mattclay
07:44:15 <gundalow> felixfontein: I'm not sure about this error https://app.shippable.com/github/ansible-collections/community.network/runs/3/2/console
07:44:17 <felixfontein> morning andersson007_! and hi mattclay! (probably more like afternoon/night?)
07:45:03 <andersson007_> hi gundalow felixfontein mattclay: ansible officially supports 2.7+ and 3.5+ python versions, correct?
07:45:25 <felixfontein> gundalow: looks like (also) an internal ansible-test error to me
07:45:41 <mattclay> andersson007_: Yes, and 2.6 on modules/module_utils.
07:46:00 <andersson007_> ok, thanks
07:46:31 <felixfontein> mattclay: btw, units/2.6 doesn't seem to run any unit test on community.general. do you know whether that is intentional?
07:47:36 <felixfontein> gundalow: it could be that ansible-test gets confused because essentially the whole collection is added in that PR. maybe merge the PR and see how it behaves afterwards?
07:48:56 <mattclay> felixfontein: Sounds like an ansible-test bug. I'm checking.
07:50:35 <mattclay> felixfontein: OK, not an ansible-test bug. Unit tests are in the wrong place. They should be under `tests/unit/plugins/{modules,module_utils}/` in collections.
07:51:25 <mattclay> They are under the old path of `tests/unit/{modules,module_utils}` which is where they are in the ansible/ansible repo. The unit test dir structure is intended to match the code under test, which is why they differ between ansible and collections.
07:51:53 <Federico87_> Morning chaps! @felixfontein if you are around, would you mind to have a look to my answers to https://github.com/ansible-collections/community.general/pull/57 so I can work on that today and hopefully push the last commit :)
07:51:53 <felixfontein> hmm, interesting. that means that the layout in community.general is also wrong
07:51:55 <Federico87_> ?
07:52:00 <felixfontein> and potentially in all migrated collections
07:52:04 <mattclay> So that's something that was overlooked in migration. All migrated collections with unit tests will be affected.
07:52:06 <mattclay> gundalow: ^
07:52:32 <mattclay> Well, with module/module_utils unit tests anyways.
07:52:41 <felixfontein> Federico87_: I will have time later today
07:52:52 <Federico87_> Thanks :)
07:53:19 <mattclay> I could detect that in ansible-test and add a warning for that situation I suppose, if anyone thinks it would be helpful.
07:53:42 <felixfontein> so both modules and module_utils need to be moved under plugins
07:54:07 <mattclay> Yes
07:54:48 <mattclay> gundalow felixfontein: That ansible-test traceback looks interesting, but nothing obvious comes to mind. I'll take a closer look.
07:57:04 <felixfontein> mattclay: gundalow: I've created PRs for community.general and community.crypto to move the unit tests
07:57:26 <mattclay> gundalow: I see something else in the logs for community.network that should be fixed: `Skipping matrix check on repo "ansible-collections/community.network" which is not "ansible-collections/general"`
07:57:53 <gundalow> mattclay: ah, thanks. I must have missed a reference.
07:59:41 <mattclay> gundalow: Ah, found the problem. The PR contains `tests/output/.tmp/` -- need to add that to `.gitignore`
08:01:14 <mattclay> gundalow: The traceback itself is still a bug that should be fixed, so feel free to open an issue for that. But the issue with the PR is the unwanted files.
08:02:43 <mattclay> It's caused by a symlink in the PR that is an absolute path that does not exist.
08:03:36 <andersson007_> does anyone know which licencing types are acceptable/preferable for community.general module_utils files?
08:04:40 <felixfontein> good question :) I'd say GPLv3+ should also be ok now. gundalow?
08:06:14 <andersson007_> :) gundalow: you're gonna made a historical decision right now
08:06:58 <andersson007_> s/made/make
08:11:56 <mattclay> Time for me to get some sleep.
08:12:32 <cybette> morning
08:12:56 <cybette> #info Playlist for contributor summit recordings: https://www.youtube.com/playlist?list=PL0FmYCf7ocraJzcnE3-VwVozQ0Zt7vm7z
08:13:42 <gundalow> mattclay: night. Thanks for your help.
08:14:20 <gundalow> andersson007_: licensing hasn't changed from Ansible/ansible, same rules apply
08:16:22 <felixfontein> good night mattclay!
08:16:32 <andersson007_> gundalow: ok, thanks
08:16:34 <felixfontein> gundalow: so still BSD only for module_utils?
08:18:30 <gundalow> #action template repo needs to include gitignore and galaxy.yml (with galaxy tags)
08:22:40 <gundalow> andersson007_: https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_in_groups.html#submitting-a-group-of-modules
08:24:15 <andersson007_> gundalow: thanks, i've already seen it, just wasn't sure about collections
08:34:17 <shaps> morning all
08:40:55 <gwmngilfen> Morning all
08:43:43 <felixfontein> morning shaps and gwmngilfen!
08:44:00 <gundalow> #action DOCS make it clear that (at least) Ansible managed/co-owned (what are we calling them) collections MUST be under the same licenses as ansible/ansible was
08:44:28 <felixfontein> can someone review https://github.com/ansible-collections/community.general/pull/77 and https://github.com/ansible-collections/community.general/pull/74 ?
08:46:20 * gwmngilfen should probably spend today making various stats projects public
08:50:51 <shaps> felixfontein: +1d both
08:51:06 <gwmngilfen> I'm not precious about showing my code - but I start a new git repo for every report or app, so there's already 40-50 of them. Can't really spam ansible-community with all that :)
08:51:15 <gundalow> felixfontein: I've merged the changelog. I don't have any MacOS knowledge so I can't review the first one
08:51:27 <gundalow> gwmngilfen: hehe, do you think you can combine them into one repo?
08:51:43 <gundalow> (even if that's one repo with 50 project directories?)
08:52:15 <gwmngilfen> Terrible idea, I think. I'm leaning towards having them under my username, and migrating any that start getting contributions
08:52:17 <felixfontein> gundalow: it's mainly changing the location of the .socks file, no mac knowledge needed (I don't have much either ;) )
08:52:41 <gundalow> DING DING DING Reminder to do `#action foo` to throw stuff in the todo list. I'll review that list, create/update issues and add to https://github.com/orgs/ansible-collections/projects/1
08:52:47 <gundalow> gwmngilfen: hehe, fair enough
08:53:24 <gwmngilfen> #action DATA publish all appropriate R code and link to it from relevant places
08:53:35 <gundalow> :)
08:53:47 <gwmngilfen> Keep me honest gundalow :)
08:54:24 <gundalow> Likewise :)
08:54:35 <gwmngilfen> I run Gitea here in the house so I can backup nonpublic stuff, so I think it's just a matter of configuring sync
08:59:18 <gwmngilfen> gundalow do I correctly recall an action to add more repos to the contributor stats? I feel that came up on Sunday
09:02:30 <felixfontein> gundalow: here's an interesting question: https://github.com/ansible-collections/community.crypto/pull/12 should module docs examples use FQCNs or not?
09:14:11 <felixfontein> gundalow: I'll create a PR to remove all network modules from community.general
09:19:50 <tadeboro> felixfontein: Last time I asked this on ansible-devel, the consensus was that yes, examples should FQCNs.
09:20:19 <felixfontein> tadeboro: I think that was us two discussing it, or was another person involved?
09:20:46 <tadeboro> felixfontein: gundalow also chimed in and this when I considered things settled ;)
09:20:54 <felixfontein> ah ok
09:21:07 <felixfontein> I just remember talking about it with one person
09:21:13 <felixfontein> memory limit reached ;)
09:21:48 <tadeboro> Year, my brain is becoming a (very short) FIFO also ...
09:37:37 <gundalow> felixfontein: I've already got a draft branch to `git rm` network content from community.general. FYI it's more complex that `git rm -rf plugins/modules/network`
09:38:37 <gundalow> gwmngilfen: https://github.com/ansible-collections/community.network/ is to be added. I didn't add it to the GoogleSheet yet. Is it possible for it to match `lib/ansible/modules/network/`
09:39:31 <jtanner> morning
09:39:40 <gwmngilfen> gundalow:
09:39:46 <gwmngilfen> EMORETEA
09:40:15 <felixfontein> gundalow: yeah, it's a lot more complex :)
09:40:22 <gwmngilfen> gundalow: yeah that'll work, the lib/ansible/modules is implied so a match of "network" should be all you need. I can add it if you wish, but it would be good to check that it works ok for you :)
09:40:31 <felixfontein> gundalow: if you want to finish it, feel free!
09:41:14 <jtanner> "yes, examples should FQCNs." ... this is true. FQCNs are a feature that should be considered the new standard, not a bug.
09:47:24 <gundalow> 1. Modules that were in `ansible/ansible` before the mass migration can continue to be used by the short form thanks to [routing.yml](https://github.com/ansible-collections/community.general/blob/master/meta/routing.yml)
09:47:24 <gundalow> 2. New modules (ie ones that have only existed in a Collection) will not work in the short form unless Playbook authors add the `collection: ` form
09:47:24 <gundalow> 3. `EXAMPLES` for new modules MUST have FQCN. This means Playbook authors can copy-paste examples without having to set `collections:`
09:47:24 <gundalow> 4. FQCN and namespaces are a feature, we want to make more people aware of them. Though we MUST NOT break 2.9 Playbooks
09:47:24 <gundalow> 5. For smaller collections like Crypto I think it's OK to bulk update all examples to use FQCN
09:47:24 <gundalow> 6. EXCEPTION: I'm not sure if it makes sense to bulk update EXISTING modules docs in community,general. I expect we will continue to move content out of community.general into smaller Collections (like we've just done with Network, rabbitmq, etc). Adding in FQCN may confuse that matter.
09:47:58 <gundalow> jtanner: does ^ sound fair (thanks for #4). Got to keep on repeating that
09:49:04 <felixfontein> 6 sounds good
09:49:10 <jtanner> sure, as long as we're not also implying we're going to keep expanding the list of "worked like 2.9" modules in routing.yml
09:49:46 <shaps> I guess the migration to use FQCN should be gradual, but we should end up with *all* examples using FQCNs
09:50:20 <felixfontein> I think so too. everything that is stable can start using FQCNs
09:50:42 <felixfontein> (i.e. that won't be moved around ;) )
09:51:40 <felixfontein> resmo: btw, how's your moving of some of the cloud modules going?
09:51:43 <resmo> I am a bit undecided whether to use fqcn or not for examples
09:51:57 <gundalow> resmo: for which collections?
09:53:31 <gundalow> 7. The list of entries in `routing.yml` was frozen in time when `pre-ansible-base` was tagged. This means NO MORE modules or plugins will be added. Hence #3
09:53:41 <resmo> from the users view, it would make sense. from a dev view, "forking" (as I already mentioned yesterday) is harder --> when forking is hard, real forks will pop up for collections
09:53:59 <gundalow> jtanner: I hadn't heard any expectation that routing.yml would be updated. Though you are right. It's good to make this explicit
09:54:19 <jtanner> me either, buy my spidey sense tingles
09:54:29 <jtanner> but*
09:55:13 <gundalow> hehe, likewise. Could be viewed as a backdoor way to keep pushing collection adoption down the path
09:55:55 * gundalow goes to put ^ in an issue
09:56:21 <resmo> felixfontein: so, vultr and exoscale should not be ready today, cloudstack is a bit more work,
09:56:31 <felixfontein> gundalow: jtanner: I guess incorrect entries of routing.yml can still be updated?
09:56:47 <jtanner> probably
09:57:10 <felixfontein> some entries are pointing to non-existing collections
09:57:22 <jtanner> and that'll continue to be an issue
09:57:40 <jtanner> which is another reason it doesn't make total sense to map out collections in core
09:58:39 <felixfontein> I'm not sure where else it should be
10:01:59 <jtanner> long term, collections need to be independent of core. it could be a mixture of server side code in galaxy and the client, or meta in the collections or other things... but we need to make it so core isn't trying to duplicate the functions of a package repository
10:02:36 <jtanner> routing.yml is a holdover feature imo to give folks that "2.9 feel", but it shouldn't be permanent
10:03:28 <gundalow> felixfontein: jtanner hum, sorry, but frozen I mean no new entries added.
10:03:43 <gundalow> I've already got it on the list that we need have tests for routing.yml
10:04:20 <felixfontein> jtanner: yep, I'd also say routing.yml in core is mainly for keeping backwards compatibility
10:04:28 <jtanner> not disagreeing. just saying even the frozen/static list should eventually go away
10:04:29 <felixfontein> so that existing playbooks/roles still work
10:04:47 <felixfontein> for 3.0? :)
10:05:01 <jtanner> :canofworms:
10:05:05 <felixfontein> lol
10:06:04 <felixfontein> once there is a good tool to convert roles/playbooks/... to FQCNs (or `collections:` adding) it will be easier to convince people to convert
10:06:23 <tadeboro> I guess routing.yml could go away in 3.0 (or 2.13 or whenever ansible is not bound anymore by compatibility promise).
10:06:25 <felixfontein> (sivels prototype for FQCN is already working quite well  I think, at least for the two files I've tested it with yet ;) )
10:06:47 <felixfontein> tadeboro: there has to be a deprecation warning first, and then four versions
10:07:12 <jtanner> yeah, when the ecosystem of tools / blogs / reddits /etc eventually make FQCNs "easy", routing.yml is definitely ready for the chopping block
10:07:14 <felixfontein> and already adding a deprecation warning to 2.10 might scare too many people
10:07:46 <felixfontein> but that's something someone else has to decide :)
10:11:40 <gundalow> Aye, one thing at a time
10:13:04 <felixfontein> yep. let's get 2.10 working first :)
10:16:35 <shaps> hm, I now started getting errors on the docs fragments, is this a known issue or am I doing something wrong?
10:17:53 <gundalow> shaps: what's the error?
10:18:12 <shaps> `ansible.errors.AnsibleError: unknown doc_fragment(s) in file plugins/modules/source_control/github/github_deploy_key.py: github`
10:18:41 <shaps> I can definitely see the fragment in `plugins/doc_fragments/github.py`
10:19:48 <felixfontein> shaps: `community.general.github` is the correct name of the docs fragment
10:21:01 <shaps> that sounds reasonable
10:21:04 <shaps> testing now
10:23:10 <shaps> yep that looks better now. Thanks felixfontein
10:23:34 <felixfontein> yw
10:26:16 <gundalow> Documented the FQCN discussion in https://github.com/ansible-collections/overview/issues/40
10:34:30 <gwmngilfen> #action DATA make the config for public apps visible and open for PRs
10:34:48 * gwmngilfen is reviewing notes from SUnday
10:50:25 <belfast77> Are there any plans to create a portable Ansible Development kit, where everything you need to get started is bundled, like the correct version of python, pip, virtalenv, tox, ansible/yaml liniting, molecule etc?
10:51:35 <belfast77> Kind of Like the Puppet Development kit (PDK), so for people like me who work inside PCI bubbles can take what they need in one hit and it be supported by Red Hat/Ansible
10:56:06 <jtanner> yes, we are likely to create something along those lines, but no, we're unlikely to package up that entire ecosystem of stuff and build it through redhat's systems and put a "supported" label on it
10:57:55 <jtanner> we don't support playbook development (only bugs), so capital S "support" on content development is very very unlikely
10:58:22 <belfast77> OK, that was a big ask :) With the "Support"
11:00:03 <jtanner> if you need some offline tooling to help with content dev, it would be great if you could either file a support ticket outlining your needs, or contact your redhat account rep and have that person feed the info to our product management
11:00:31 <jtanner> the latter usually has more weight
11:01:25 <belfast77> will do, right away, thanks @jtanner
11:02:00 <jtanner> np
11:07:20 <sshnaidm> belfast77, it could be community supported container, for example
11:07:56 <sshnaidm> in some contrib/ folder
11:12:18 <gwmngilfen> #action DATA take a stab at differentiating unmaintained from stable repos, possibly via time-to-1st-comment survival or issues-to-PRs ratio
11:12:45 * gwmngilfen feels a logistic regression coming on for that...
11:14:53 <jtanner> if unmaintained, there's bound to be logical regressions =P
11:20:37 * felixfontein -> lunch
11:21:10 <gwmngilfen> jtanner: quit trolling me, you know logistic != logical :P
11:21:30 <jtanner> trolling is my job
11:21:49 <gwmngilfen> yes, but you're supposed to hide behind ansibot, right? :P
11:21:56 <jtanner> oh oops
11:44:01 * shaps -> lunch
11:57:14 <belfast77> @sshnaidm thanks, sorry I was on a call discussing this. we are going to raise it with our account manager
12:03:33 <felixfontein> re
12:10:01 <resmo> re
12:23:23 <gundalow> Somepoint pointed me to https://www.w3.org/2001/12/zakim-irc-bot.html which is what w3 use to run meetings. The ability to add items to a queue looks interesting
12:25:14 <misc> wow, that bot seems almost old enough to order drink over irc in some part of the US
12:25:54 <felixfontein> lol
12:26:24 <misc> but yeah, I think it would be useful to have something better than meetbot
12:26:33 <misc> (who is kinda unmaintained, IIRC)
12:27:44 <misc> I kinda think that could be a interesting internship for RH, some coding, some interview to find what people need for meetings
12:34:46 <jtanner> fyi, /rebuild_failed is live on ansible/ansible
12:34:54 <gundalow> \o/
12:35:03 <gundalow> resmo: felixfontein agaffney ^
12:35:41 <agaffney> how do I use it? I don't think I've ever actually used a bot command before
12:35:58 <agaffney> also, will that eventually apply to the collection repos, as well?
12:36:41 <resmo> jtanner: nice
12:36:50 <gundalow> agaffney: just add a single comment `/rebuild_failed` on a PR
12:37:10 <felixfontein> tested it, it works!
12:37:15 <gundalow> When we rebase the collections branch for the bot we will get that feature
12:37:17 <felixfontein> https://github.com/ansible/ansible/pull/66920 (see last comment)
12:37:37 <felixfontein> apropos, when will we get ansibot on community.general?
12:38:03 <gundalow> felixfontein: somepoint next month, hopefully earlier
12:38:24 <gundalow> It's in the list once other content has moved has moved out and CI is good
12:39:13 * agaffney twiddles his thumbs waiting for the bot to pick up his `/rebuild_failed` comment
12:43:13 <agaffney> it looks like it's working
12:43:57 <felixfontein> \o/
12:45:41 <gundalow> `Showing 1,934 changed files with 0 additions and 344,418 deletions.`
12:50:58 <felixfontein> yay \o/
12:53:11 <gundalow> so in community.network we have subdirectories, like in community.general
12:53:30 <gundalow> and symlinks in plugins/modules
12:53:31 <felixfontein> makes sense
12:54:02 <gundalow> though getting `ERROR: plugins/modules/avi_alertscriptconfig.py:0:0: missing: __metaclass__ = type` even though got `plugins/modules/network/avi/avi_alertscriptconfig.py validate-modules:doc-missing-type`
12:55:39 <felixfontein> in community.network?
12:55:45 <felixfontein> are you sure it is a symlink, and not a copy of the module?
12:57:04 <gundalow> headesk
12:57:06 <gundalow> thanks felixfontein
13:01:53 <felixfontein> gundalow: I think you want to rebase your PR https://github.com/ansible-collections/community.general/pull/84 to current master, because f.ex. many unit tests have been moved, and the ignore.txt files have been updated
13:02:14 <felixfontein> (and you hvae a lot of dead symlinks to remove :) )
13:15:53 * gundalow finds this handy oneliner `find . -xtype l -delete`
13:16:28 <felixfontein> yep, that one is very useful :)
13:16:45 <felixfontein> unfortunately I always forget about xtype shortly after I use it...
13:17:20 <gundalow> I didn't know about it till now
13:21:59 <shaps> Omg I think I’m done with the github changes
13:23:09 <shaps> I wanted to add some integration tests, but init sure how to test (mostly needs a repo and a token)
13:23:20 <shaps> *not sure
13:23:46 <gundalow> shaps: Excellent
13:24:22 <gundalow> shaps: The existing `git` integration tests use some GitHub repos to talk to
13:24:47 <shaps> Yeah, but most of the github modules are “destructive”
13:25:10 <shaps> (create/remove webhooks, deploy keys, etc.)
13:26:02 <shaps> I have been using a repo under my username for my own testing, but I don’t really want to receive an email for a dummy deploy key being added when CI runs :D
13:26:20 <felixfontein> resmo: the CS error is really strange, your additional setup now runs, but it doesn't help: https://app.shippable.com/github/ansible-collections/community.general/runs/318/98/console
13:30:19 <gundalow> shaps: For testing, is it OK that we use github.com
13:31:09 <shaps> Yes that’s what it is currently using
13:31:22 <shaps> Give me 10 min I’ll send the PR, makes it easier
13:34:47 <felixfontein> gundalow: a couple of unit tests still need to be deleted, and a huge amount of ignore.txt entries, but besides that CI looks good for your PR :)
13:35:19 <felixfontein> gundalow: btw, shippable runs two CI runs for your PRs (maybe only when it is a branch in the repo itself, and not a branch in a fork?)
13:41:30 <resmo> felixfontein: hopefully my latest commit should "fix" cloudstack ci
13:42:45 <felixfontein> resmo: good luck! do you have any idea why this is "suddenly" failing?
13:44:03 <resmo> yes, the tests were split up into 2 groups, in one of the groups the "creating a VM" fails because of the slow startup of the test container.
13:44:37 <resmo> it is more a cloudstack issue rather than a ansible issue
13:45:15 <resmo> (we were just lucky in the past not hitting this issue)
13:46:00 <felixfontein> gundalow: you also removed all cloudscale integration tests (cs_*) in your PR
13:46:17 <felixfontein> resmo: ah, so it was essentially pure luck :)
13:47:45 <shaps> gundalow: Right, have a look at the github_webhook test as an example - https://github.com/ansible-collections/community.general/pull/85/files#diff-4aa737321a2dd6a6936e3a0c18b9c8deR1
13:48:43 <shaps> https://github.com/ansible-collections/community.general/pull/85 <- if anyone wants to have a look/review, please be nice :)
13:50:44 <shaps> the fun bit will be when I have to "backport" this to 2.9 :D
13:50:53 <shaps> Not even sure it's doable/worth
13:53:25 <gundalow> shaps: community.general will most likely NOT work with 2.9
13:53:42 <gundalow> I personally don't think it's worth the time to do stuff with 2.9 + collections
13:54:01 <shaps> yeah, but I've done all those changes because I need them at $JOB :D
13:54:11 <gundalow> #action DOCS Collections and 2.9: not really a priority. ansible-base (2.10) already exists
13:54:12 <shaps> So one way or another I'm going to have to make it work for 2.9 :P
13:54:17 <gundalow> shaps: because work needs 2.9?
13:54:23 <felixfontein> gundalow: what do you think will block using community.general (or at least parts of it) with 2.9?
13:54:39 <felixfontein> probably because work needs 2.9 at least until 2.10 is there :)
13:55:14 <shaps> gundalow: I upgraded to 2.9 a couple weeks ago, still had to support stuff (poorly) written for v2.4 or something like that
13:56:10 <shaps> also work uses tower, so until I get a stamp from RH Support that I can upgrade to 2.10 + collections, it's not going to happen
13:58:50 <felixfontein> btw, shaps, if you have more time for reviewing: https://github.com/ansible-collections/community.crypto/pulls/ :)
13:59:07 <shaps> yep
13:59:25 <shaps> any one in particular or just all of them?
13:59:56 <felixfontein> #6, #8, #10 should be easiest
14:00:13 <felixfontein> and #12 probably too
14:00:51 <felixfontein> btw, if you wouldn't have replaced ' with " in the github modules, the diff would be a lot simpler to read :D
14:01:19 <shaps> hah, blame "black" for it :)
14:01:34 <felixfontein> what's "black"?
14:01:43 <felixfontein> (I hate to google for that, it's too generic ;) )
14:02:22 <resmo> felixfontein: gofmt for python ;)
14:02:29 <felixfontein> ah
14:02:43 <shaps> yep, what resmo said
14:03:22 <bcoca> 'blame black' googling can be pretty nsfw
14:03:29 <resmo> lol
14:03:35 <felixfontein> shaps: please undo the x -> _x renames, that doesn't work in collections anymore
14:04:09 <shaps> the filename you mean?
14:04:29 <felixfontein> yes
14:04:35 <shaps> k sure
14:04:45 <felixfontein> also you're missing a changelog fragment :)
14:05:13 <Federico87_> What is the best way to send a sequence of commands with `run_command`? i.e. `cd`, `ls`, `touch` If I pass all of them in a single list the terminal believes that `ls` is the folder where it has to `cd`I tired to add `;` like `cd` `;` `ls` `;` `touch`
14:05:19 <Federico87_> I can put each command in a separate list but and pass each list with a for loop to `run_command` but I was wondering if there is a more elegant way to do it
14:05:21 <shaps> felixfontein: yep, I've put [WIP] for a reason!
14:06:54 <shaps> bcoca: yeah, I don't even want to think about what the results would look like
14:14:30 <felixfontein> shaps: thanks for reviewing!
14:14:42 <felixfontein> resmo: do you mind if I merge https://github.com/ansible-collections/community.crypto/pull/12 ?
14:15:17 <felixfontein> resmo: if someone wants to fork it, they currently have to do a big search+replace anyway
14:15:51 <felixfontein> (already just for docs fragments, where there's no relative way to write them AFAIK)
14:16:45 <felixfontein> Felden: I don't think run_command is thought to run a series of commands. in your terminal, that only works because the shell essentially sees your line as a program and runs that program by executing the individual steps
14:16:52 <felixfontein> oh, sorry
14:17:11 <felixfontein> this should have gone to Federico87_
14:18:21 <gundalow> hum, so do directories under `plugins/` need `__init__.py`? Looking at collections we seem to be inconsistent
14:19:30 <gundalow> #action DOCS and CI test for `__init__.py` existing (or not?!??!) under collection's `plugin/` and `tests/utils` directory structure
14:19:44 <gundalow> DING DING DING! DaWGs (Documentation working group) meeting in #ansible-docs in 10 minutes. We have a fun filled agenda this week! - https://github.com/ansible/community/issues/521#issuecomment-600166114
14:23:02 <resmo> felixfontein: meeeeerge ;)
14:24:12 <felixfontein> resmo: thanks!
14:24:46 <gundalow> felixfontein: regarding 2.9 vs 2.10 + collections. 1) Routing & tombstoning will not be backported to 2.9, so will have to use FQCN. 2) Deprecated modules may not work (same PR) 3) We aren't testing against 2.9, therefore have to assume it is broken
14:24:54 <felixfontein> hmm, I think the cisco.aci collection updated and broke the community.general CI: `ERROR! module community.general.aci_interface_policy_fc missing documentation (or could not parse documentation): unknown doc_fragment(s) in file /root/ansible/ansible_collections/community/general/plugins/modules/aci_interface_policy_fc.py: cisco.aci.modules`
14:25:51 <felixfontein> gundalow: 1) true, but it should be ok to use some new features from it; 2) that's probably the worst part; 3) that's something we could change ;) but let's definitely focus on 2.10 first :)
14:26:32 <gundalow> #action Collection + 2.9 testing (backlog)
14:26:34 <felixfontein> resmo: can you take a look at https://github.com/ansible-collections/community.crypto/pull/11/files ?
14:27:41 <felixfontein> resmo: btw, are you still interested in co-maintaining the acme_* modules? (or even some more crypto modules?)
14:30:06 <felixfontein> shaps: any thoughts on https://github.com/ansible-collections/community.crypto/pull/7 ? (the general idea, not that it now has conflicts :D )
14:38:54 <abadger1999> @gundalow:  they should not need __init__.py
14:40:52 <abadger1999> gundalow: ansible has a custom python loader which makes the __init__.py unnecessary for python2 (it's used in python3 as well but python 3 would already find them... They're python 3 namespaces packages)
14:41:18 <gundalow> abadger1999: Thanks for the info
14:55:14 <shaps> felixfontein: I don't think I've ever been against the change
14:55:57 <felixfontein> shaps: I don't think anyone really is, but if nobody mentions anything, nothing will happen :D
14:57:30 <shaps> yes, that was to say I'm going to +1 it :)
14:57:39 <felixfontein> shaps: hehe ok, thanks! :)
15:01:06 <shaps> left a comment saying I'm +1, I'll review the actual changes in a bit
15:02:10 <felixfontein> thanks!
15:24:24 <resmo> hmm can anyone enlighten me, why does collection build fail by looking into a path cloudstack/cloud in my cloudstack collection?
15:24:26 <resmo> https://github.com/ngine-io/ansible-collection-cloudstack/runs/549147037
15:24:50 <resmo> (path does not exist because the modules are right in plugins/modules
15:25:43 <resmo> ehn never mind
15:38:06 <resmo> what was the irc handle of the other greg?
15:38:26 <gwmngilfen> me?
15:38:28 <gwmngilfen> :D
15:38:41 <gwmngilfen> ?me <- stats greg
15:38:49 <resmo> gwmngilfen: ah k ;) yeah
15:38:51 <gwmngilfen> aaaaand I fail at typing
15:39:22 <resmo> gwmngilfen: do you already have a stat of collections showing up per day on galaxy?
15:39:30 <felixfontein> gwmngilfen is the greg with the name I neither can remember to pronounce or to spell...
15:39:33 <gwmngilfen> i do not
15:39:53 <gwmngilfen> felixfontein: gun-gil-ven
15:40:28 <gwmngilfen> resmo: that's not a bad idea, although it's been a while since I messed with the galaxy API
15:40:41 <felixfontein> gwmngilfen: thanks! I'm afraid I won't remember that tomorrow anymore, though :)
15:40:45 <gwmngilfen> #action DATA graph new collections over time on Galaxy
15:41:03 <gwmngilfen> felixfontein: just call me "gwim" then, everyone else does :P
15:41:05 <resmo> gwmngilfen: cool thx
15:41:24 <felixfontein> lol ok :)
15:41:30 <felixfontein> or use tab completion ;)
15:41:35 <felixfontein> (at least here in IRC)
15:41:39 <gwmngilfen> resmo: if you're not already aware, stats.eng.ansible.com/apps is my playground. I'll let you know if I get anything working :P
15:44:00 <resmo> gwmngilfen: nice
16:38:38 <webknjaz> @sshnaidm: FYI I've added some post-mortem comments on the podman collections PR # 15
16:49:29 <mattclay> felixfontein: Yes, double-runs is one issue with opening PRs using a branch in the repo instead of a fork. Shippable can be configured to not do that, but then you have to whitelist or blacklist branches to make that work. Between that and non-fork branches polluting other people's forks, we've tried to avoid PRs without using forks.
16:50:31 <sshnaidm> webknjaz, thanks, looking
16:55:37 <felixfontein> mattclay: thanks for the explanation!
16:59:08 <felixfontein> mattclay: I'm currently trying to add basic Ansible 2.9 CI to community.crypto, and first thought I'd use the group for that (we only have one group). but that obviously doesn't work for integration tests (as I've realized now :) ). is it possible to add more things to the node name after another '/'? like having nodes 'units/2.7/1/devel' and 'units/2.7/1/2.9'?
17:01:35 <mattclay> felixfontein: I'd probably add it before the group, not after. Either way, you probably want to modify `shippable.sh` to handle that and strip off the prefix/suffix before passing it to the existing job scripts, so they won't need any modifications.
17:02:45 <mattclay> felixfontein: Maybe look at it as a prefix and a suffix and see which appears to be more readable.
17:03:09 <felixfontein> mattclay: ok, I assumed I have to do that anyway. I was mainly concerned with shippable having problems with this, I don't know how flexible it is :)
17:03:16 <felixfontein> thanks, I'll try it out
17:04:27 <mattclay> felixfontein: If the labels are too long they may get truncated in the UI or otherwise make the matrix difficult to read, so play around with it a bit to see what works.
17:05:05 <mattclay> Shippable itself doesn't care what the labels look like. That's entirely up to the shell scripts we run in CI.
17:05:59 <felixfontein> ok, thanks!
17:18:48 <felixfontein> I think prefix works pretty well, thanks for that suggestion: https://app.shippable.com/github/ansible-collections/community.crypto/runs/45/summary/console
17:20:56 <gundalow> #action gundalow contact all collection owners to update Unit test directories; Python imports; ignore.txt
17:21:31 <felixfontein> gundalow: which python imports do you mean?
17:22:49 <gundalow> felixfontein: I assume if the unit tests import other unit tests they may need updating?
17:23:10 <gundalow> maybe that isn't the case ever.
17:23:14 <gundalow> actually probs never
17:24:25 <felixfontein> you mean import other unit tests from other collections? or you mean from community.general?
17:24:42 <felixfontein> ah, you mean after renaming the unit test directory
17:24:46 <felixfontein> (I think?)
17:26:01 <felixfontein> hmm, btw, some parts of community.general definitely do not work with Ansible 2.9; for example the archive module uses an Ansible-2.10-only feature (optional path argument to load_file_common_arguments)
17:26:53 <bcoca> 'mostly works'
17:26:59 <felixfontein> yep
17:28:02 <felixfontein> it's not impossible to work around this, but I guess not really worth most of the time :)
17:28:10 <bcoca> one question for colections in general, do you add 'compat code' so you work across more ansible versions or set 'required' ansbile version and people need to downgrade to get compatible (going forward, 2.8/2.9 barely support collections)
17:28:38 <bcoca> felixfontein: you 'can' work around it by catching exception and 'reattempting' args w/o the 'path'
17:28:55 <bcoca> i would not advise doing that, but 'possilbeish'
17:30:46 <felixfontein> I just did that for one place in community.crypto's module_utils :) I'd really like to support 2.9, at least as long as 2.10 is not released
17:31:10 <rmarcand> hello guys, do you have any example how can I grab a Bearer token using ansible?
17:33:17 <felixfontein> ok, some longer time ago I apparently used archive+unarchive to do what copy can also do...
17:34:54 <bcoca> felixfontein: probalby worked LOTs faster
17:34:59 <bcoca> also ... syncrhonize ...
17:35:24 <bcoca> rmarcand: dont know of any examaples, but uri/get_url modules should be able to
17:35:24 <felixfontein> lol
17:35:48 <rmarcand> @bcoca thank you
17:36:12 <felixfontein> I'm even more scared of synchronize, since I found out that it uses internals of the docker connection plugin
17:36:45 <bcoca> felixfontein: soo many wrong things there ...
17:37:05 <felixfontein> yeah, I heard about it, but seeing it with your own eyes makes it even worse ;)
17:37:29 <misc> that explain the quote of Dune at the start of the file
17:40:01 <bcoca> i would have gone with Dante's Inferno quote ...
17:59:38 <felixfontein> mattclay: I think change detection for collections in Ansible 2.9's ansible-test is broken: https://app.shippable.com/github/ansible-collections/community.crypto/runs/47/6/console when running with ci_complete, it works fine: https://app.shippable.com/github/ansible-collections/community.crypto/runs/49/6/console
18:04:56 <mattclay> felixfontein: Yeah, there have been bugfixes for that in devel that I haven't backported to 2.9. I'll try to track them down and get them backported.
18:20:16 <felixfontein> mattclay: thanks!
18:45:29 <gundalow> There have been some good updates on FQCN in examples, other feedback is welcome https://github.com/ansible-collections/overview/issues/40
18:52:54 <gundalow> Anyone else still hacking?
18:53:01 <gundalow> wondering if I should `#endmeeting`
18:53:29 <felixfontein> I'm currently eating dinner, but I'll do a bit later maybe :)
18:53:33 <felixfontein> I guess #endmeeting is fine
18:54:19 <gundalow> #chair
18:54:19 <zodbot> Current chairs: andersson007_ cybette dmellado felixfontein gundalow gwmngilfen phips resmo shaps
18:54:26 <gundalow> Thank you everybody!
18:54:33 <gundalow> Lots of cool stuff has been done
18:54:36 <gundalow> #endmeeting