ansible_community_pr_review
12.00
February 21, 2019
ansible-community
#ansible-community: Ansible Community PR Review
Meeting started by gundalow at 12:00:39 UTC
(full logs ).
Meeting summary
Bug PR review (gundalow , 12:08:54)
First query
https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+-label%3Abackport++-label%3Asupport%3Acore+-label%3Asupport%3Acurated+-label%3Anetworking+-label%3Anew_module+-label%3Aaws+-label%3Aazure+-label%3Adocker+-label%3Alinode+-label%3Avmware++-label%3Awindows++label%3Abug+-label%3Aaws+-label%3Aazure+-label%3Adocker+-label%3Alinode+-label%3Anetworking+-label%3Avmware+-label%3Awindows
(gundalow ,
12:09:16)
https://github.com/ansible/ansible/pull/52699
os_coe_cluster module overrides param labels with wrong behavior
#52699 (gundalow ,
12:12:21)
https://github.com/ansible/ansible/pull/52685
gcp_compute: use env variables on inventory script (gundalow ,
12:17:00)
https://github.com/ansible/ansible/pull/52675
Fix redfish_facts GetPsuInventory command not returning correct
output (gundalow ,
12:18:30)
https://github.com/ansible/ansible/pull/52668
Use local dummy repo for flatpak_remote integration tests (gundalow ,
12:21:11)
ACTION : ask mattclay
to review 52668 (gundalow ,
12:25:16)
https://app.shippable.com/github/ansible/ansible/runs/108979/77/console
(gundalow ,
12:28:40)
https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html
(akasurde ,
12:29:47)
https://github.com/ansible/ansible/pull/52642
VMware: Refactor guest inventory plugin (gundalow ,
12:32:41)
ACTION : lib/ansible/plugins/inventory/vmware needs adding to
BOTMETA (gundalow ,
12:33:56)
https://github.com/ansible/ansible/pull/52594
redhat_subscription: Exempt register vars from shell expansion (gundalow ,
12:38:17)
ACTION : merge
52594 (gundalow ,
12:49:06)
We don't merge during today as this allows
people to continue to review and add comments. (gundalow ,
12:49:24)
https://github.com/ansible/ansible/pull/52553
Add Hetzner Cloud Inventory Plugin (gundalow ,
12:50:03)
ACTION : See if
plugins/inventory have some built-in for reading env, if so update
https://docs.ansible.com/ansible/devel/plugins/inventory.html
(gundalow ,
13:07:40)
https://github.com/ansible/ansible/pull/52574
postgresql_privs change fail to warn if role(s) does not exist (gundalow ,
13:08:03)
https://github.com/ansible/ansible/pull/52564
pids: case insensitive string comparison for process names (gundalow ,
13:26:55)
ACTION : merge 52564
(no backport, new in 2.8) (gundalow ,
13:30:00)
https://github.com/ansible/ansible/pull/52452
osx_defaults: refactor (gundalow ,
13:31:01)
https://github.com/ansible/ansible/pull/52234
Fix reviews issues for scaleway_lb (gundalow ,
13:38:01)
ACTION : merge 52234
(no backport) (gundalow ,
13:43:06)
https://github.com/ansible/ansible/pull/52166
Fix idempotence in rabbitmq_plugin (gundalow ,
13:43:28)
ACTION : merge &
backport 52166 (gundalow ,
13:48:49)
https://github.com/ansible/ansible/pull/52721
identity: Issue warning if GSSAPI parameters can't be used (gundalow ,
13:50:06)
ACTION : 52721 merge
(no backport) (gundalow ,
13:54:21)
https://github.com/ansible/ansible/pull/52117
archive: Fix empty files to dest (gundalow ,
13:55:28)
https://github.com/ansible/ansible/pull/52234#pullrequestreview-206316858
(dag ,
13:59:15)
https://github.com/ansible/ansible/pull/52117
archive: Fix empty files to dest (gundalow ,
14:00:16)
https://github.com/ansible/ansible/pull/52004
terraform: patch state 'planned' outputs and perform minor refactor
(gundalow ,
14:05:55)
https://github.com/ansible/ansible/pull/36811
Fixed lvol ValueError with float size. (gundalow ,
14:11:04)
ACTION : review and
possibly merge 36811 (gundalow ,
14:21:21)
ACTION : merge
52004 (gundalow ,
14:23:15)
https://github.com/ansible/ansible/pull/51953
onepassword_facts bug fixes (gundalow ,
14:23:39)
https://github.com/ansible/ansible/pull/45355
mysql_user: fix compatibility issues with various MySQL/MariaDB
versions (gundalow ,
14:30:21)
https://github.com/ansible/ansible/pull/51938
rhsm_repository: Properly handle no repos (gundalow ,
14:50:49)
ACTION : merge 51938
& backport once changelog has been added (gundalow ,
14:52:26)
https://github.com/ansible/ansible/pull/51916
extra_args_precommand parameter added to zypper_repository module
(gundalow ,
14:52:58)
ACTION : merge
51916 (gundalow ,
14:57:20)
https://github.com/ansible/ansible/pull/51721
flatpak_remote: Fixing out of index error (gundalow ,
15:01:29)
https://github.com/ansible/ansible/pull/51721#issuecomment-464827401
(bmalynovytch[m] ,
15:08:18)
https://github.com/ansible/ansible/pull/51594
crypttab: Trim trailing newlines (gundalow ,
15:11:54)
https://github.com/ansible/ansible/pull/51594
crypttab: Trim trailing newlines (gundalow ,
15:14:08)
ACTION : merge &
backport (with changelog) 51594 (gundalow ,
15:15:17)
https://github.com/ansible/ansible/blob/d7f334b92164775b51e386dd3fe62e1466e0184a/lib/ansible/modules/system/crypttab.py#L245
(bmalynovytch[m] ,
15:15:55)
https://github.com/ansible/ansible/pull/51541
lxd_container fix to check for snap package install unix.socket
(gundalow ,
15:16:03)
ACTION : see if 51541
has +1's and merge if needed (gundalow ,
15:21:13)
https://github.com/ansible/ansible/pull/51505
https://github.com/ansible/ansible/pull/51505 (gundalow ,
15:24:52)
https://github.com/ansible/ansible/pull/51130
Update filetree.py to allow lists as input (gundalow ,
15:27:00)
ACTION : gundalow
review BOTMETA and add (lookup) plugin maintainers (gundalow ,
15:31:11)
https://github.com/ansible/ansible/pull/51064
fix(rabbitmq_plugin): fixed an issue, when module successfully
reports installation of non existing plugins (gundalow ,
15:36:43)
ACTION : merge
51064 (gundalow ,
15:41:21)
https://github.com/ansible/ansible/pull/50763
Fix Grafana dashboard overwriting (gundalow ,
15:45:22)
ACTION : 24550 check
CI status and merge once stale_ci has been removed (gundalow ,
15:47:42)
ACTION : merge
49981 (gundalow ,
16:42:04)
https://github.com/ansible/ansible/pull/49943
Fix netbox url with string concat (gundalow ,
16:43:16)
ACTION : review,
merge, add comment about backport on 49776 (gundalow ,
16:44:42)
we've covered 52721 - 49665, which takes us to
last PR review (19th Dec 2018) (gundalow ,
16:46:59)
Docs PR review (gundalow , 16:47:05)
Docs PRs
https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+label%3Adocs+-label%3Awip+sort%3Acreated-asc+
(gundalow ,
16:48:48)
ACTION : merge
24550 (gundalow ,
16:50:26)
https://github.com/ansible/ansible/pull/13620
update_json for module intermediate comm (gundalow ,
16:51:21)
https://github.com/ansible/ansible/pull/39114
Adding haversine filter - mathstuff.py (gundalow ,
16:59:26)
https://github.com/ansible/ansible/pull/39174
Passing environmental variable to task definition (gundalow ,
17:11:18)
https://github.com/ansible/ansible/pull/37080
Environment file feature (gundalow ,
17:13:50)
https://github.com/ansible/ansible/pull/42775
(acozine ,
17:50:34)
ACTION : - verify
output on https://github.com/ansible/ansible/pull/43993/files and
merge (samccann ,
18:18:50)
ACTION : gundalow to
create fresh https://github.com/ansible/ansible/pull/44986 and use
`C(...)` (gundalow ,
18:22:50)
https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/google/gcp_compute_network_facts.py#L152
(samccann ,
18:32:02)
ACTION : merge
52553 (gundalow ,
18:40:08)
ACTION : review docs
portion and merge 49006 (samccann ,
18:46:13)
ACTION : gundalow to
create new PR to replace 49705 (gundalow ,
18:54:09)
ACTION : merge
50204 (samccann ,
19:01:12)
ACTION : - add docs
review to https://github.com/ansible/ansible/pull/52355 (samccann ,
19:34:00)
Meeting ended at 19:40:22 UTC
(full logs ).
Action items
ask mattclay to review 52668
lib/ansible/plugins/inventory/vmware needs adding to BOTMETA
merge 52594
See if plugins/inventory have some built-in for reading env, if so update https://docs.ansible.com/ansible/devel/plugins/inventory.html
merge 52564 (no backport, new in 2.8)
merge 52234 (no backport)
merge & backport 52166
52721 merge (no backport)
review and possibly merge 36811
merge 52004
merge 51938 & backport once changelog has been added
merge 51916
merge & backport (with changelog) 51594
see if 51541 has +1's and merge if needed
gundalow review BOTMETA and add (lookup) plugin maintainers
merge 51064
24550 check CI status and merge once stale_ci has been removed
merge 49981
review, merge, add comment about backport on 49776
merge 24550
- verify output on https://github.com/ansible/ansible/pull/43993/files and merge
gundalow to create fresh https://github.com/ansible/ansible/pull/44986 and use `C(...)`
merge 52553
review docs portion and merge 49006
gundalow to create new PR to replace 49705
merge 50204
- add docs review to https://github.com/ansible/ansible/pull/52355
Action items, by person
gundalow
gundalow review BOTMETA and add (lookup) plugin maintainers
gundalow to create fresh https://github.com/ansible/ansible/pull/44986 and use `C(...)`
gundalow to create new PR to replace 49705
UNASSIGNED
ask mattclay to review 52668
lib/ansible/plugins/inventory/vmware needs adding to BOTMETA
merge 52594
See if plugins/inventory have some built-in for reading env, if so update https://docs.ansible.com/ansible/devel/plugins/inventory.html
merge 52564 (no backport, new in 2.8)
merge 52234 (no backport)
merge & backport 52166
52721 merge (no backport)
review and possibly merge 36811
merge 52004
merge 51938 & backport once changelog has been added
merge 51916
merge & backport (with changelog) 51594
see if 51541 has +1's and merge if needed
merge 51064
24550 check CI status and merge once stale_ci has been removed
merge 49981
review, merge, add comment about backport on 49776
merge 24550
- verify output on https://github.com/ansible/ansible/pull/43993/files and merge
merge 52553
review docs portion and merge 49006
merge 50204
- add docs review to https://github.com/ansible/ansible/pull/52355
People present (lines said)
gundalow (291)
samccann (96)
acozine (83)
bmalynovytch[m] (70)
bcoca (46)
akasurde (31)
dag (24)
zodbot (21)
LukasKaemmerling (18)
webknjaz (15)
alongchamps (14)
cabral404 (14)
resmo (14)
akasurde_ (11)
sivel (6)
themroc (6)
hvtuananh (6)
orthanc (6)
winem_ (6)
mrproper (5)
moshloop_ (5)
felixfontein (4)
ironfroggy (2)
dbpiv (2)
navalkp (2)
stroobl (2)
baptistemm_ (1)
ezmac (1)
Pilou (1)
kkao07 (1)
bmalynovytch (1)
Generated by MeetBot 0.1.4.