00:00:09 <jborean93> #startmeeting Ansible Azure Working Group
00:00:09 <zodbot> Meeting started Thu May 30 00:00:09 2019 UTC.
00:00:09 <zodbot> This meeting is logged and archived in a public location.
00:00:09 <zodbot> The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:09 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:09 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:01:17 <jborean93> hello
00:01:22 <MyronFanQiu> Hello :)
00:01:35 <jborean93> how are you goin?
00:02:36 <jborean93> hey Zim
00:02:44 <MyronFanQiu> I'm fine recently. Working on some modules and issues :)
00:03:42 <jborean93> that's good to hear
00:03:54 <jborean93> nitzmahone is unable to make it this week
00:04:08 <jborean93> anything you wish to discuss?
00:05:07 <zikalino82654415> i think not much from me today.
00:06:10 <MyronFanQiu> Should we wait for Catherine? I'm not sure she is available or not? zim do you know this?
00:06:31 <MyronFanQiu> I prepared a PR for review
00:06:52 <zikalino82654415> yes, so go ahead MyronFanQiu
00:07:59 <MyronFanQiu> This one about policy set definition. https://github.com/ansible/ansible/pull/55791
00:09:37 <jborean93> this seems wrong https://github.com/ansible/ansible/pull/55791/files#diff-e976451c791a19a0b4fa56e36d7d9c1eR10
00:11:08 <MyronFanQiu> oh. There are two PRs and concepts, one is policy definition and another is policy set definition
00:11:43 <jborean93> even the `policy_definitions` option doesn't look right
00:12:17 <jborean93> you are setting a string, that is an array of a dict that contains the key `policyDefinitionId`
00:12:59 <jborean93> I don't know the API but having something that takes a raw value expected by SDK is not a good thing to do
00:13:39 <jborean93> if it is referring to a policy definition, it should take in an ID or some other key field that the module can use to lookup the proper value
00:13:51 <jborean93> it shouldn't be up to the user to figure that out
00:14:18 <MyronFanQiu> It supports both the list and the string input
00:16:53 <jborean93> I don't know the API at all but you may want something similar to this https://www.irccloud.com/pastebin/cvVXggFK/
00:17:34 <jborean93> basically you should just be able to specify a list of policy definitions by some key value. If it is required you could make each list entry a dict with whatever key/values you need
00:19:00 <MyronFanQiu> Yes. The user can do like this.
00:19:03 <MyronFanQiu> so you mean
00:19:22 <MyronFanQiu> it should not support a string input
00:20:08 <jborean93> what are you trying to do with this field?
00:21:51 <MyronFanQiu> because if you search the knowledge about this field, the doc will teach you how to write it in json format
00:22:07 <yungezz> Sorry for be late
00:22:10 <jborean93> you can't assume that people who use Ansible know, or care, about the Azure SDK docs
00:22:50 <jborean93> Ansible isn't designed just around developers. Our module interface should be a simple to use interface into the resource that abstracts the information that the SDK requires
00:23:11 <jborean93> whether that be the module translates a key field into the JSON structure that required or something else
00:24:27 <yungezz> Are you talking about policy definition
00:24:36 <jborean93> and policysetdefinition
00:25:08 <jborean93> currently it's around the UI for https://github.com/ansible/ansible/pull/55791/files#diff-3f78e896114b8c19e1148e41492d777dR85
00:26:50 <yungezz> We can look at the Json to see how to add properties as ui arguments
00:29:26 <jborean93> it sounds like in this case, the values are trying to reference an existing policy definition. It sounds like a simple list should suffice. I'm just not sure if you need to add any extra fields to select a different resource group or something
00:30:36 <yungezz> Policy definition could be on scope other than resource group, right? MyronFanQiu
00:31:11 <MyronFanQiu> Yes
00:31:16 <jborean93> yea not sure what the correct terminology here is, but in that case I would say it should accept a list of strings, or a list of dicts
00:31:29 <jborean93> the string entry would then look in the same scope as the policy set definition
00:31:53 <jborean93> a dict would then have extra keys you can use to set the scope accordinly
00:31:58 <jborean93> accordingly*
00:32:27 <yungezz> Sounds good to me
00:32:30 <MyronFanQiu> for the policy_definitions in the policy set definition module, I understand and agree only support the list should suffice
00:32:41 <MyronFanQiu> or list of dicts
00:33:01 <jborean93> yep, you should document what those keys are and not have it free form
00:35:18 <jborean93> is there anything else we wish to discuss?
00:35:30 <yungezz> No from me
00:37:29 <jborean93> cool, if there's nothing else I'll end the meeting
00:37:49 <yungezz> Thanks all!
00:37:53 <jborean93> #endmeeting