17:37:42 <abuzachis[m]> #startmeeting Ansible AWS Community Meeting
17:37:42 <zodbot> Meeting started Thu Apr 27 17:37:42 2023 UTC.
17:37:42 <zodbot> This meeting is logged and archived in a public location.
17:37:42 <zodbot> The chair is abuzachis[m]. Information about MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions.
17:37:42 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
17:37:42 <zodbot> The meeting name has been set to 'ansible_aws_community_meeting'
17:38:01 <abuzachis[m]> #agenda https://github.com/ansible/community/issues/687
17:38:25 <abuzachis[m]> Not sure if that works. However, this is the agenda.
17:39:05 <jillr> o/  I'm also in another meeting but I can keep half an eye here
17:40:27 <abuzachis[m]> @chair markuman tremble jillr Helen Bailey gomathiselvi Mandar Kulkarni
17:40:43 <abuzachis[m]> s/@/#/
17:41:57 <abuzachis[m]> #chair markuman tremble jillr Helen Bailey gomathiselvi markuman
17:41:57 <zodbot> Current chairs: Bailey Helen abuzachis[m] gomathiselvi jillr markuman tremble
17:42:11 <abuzachis[m]> #chair Mandar Kulkarni
17:42:11 <zodbot> Current chairs: Bailey Helen Kulkarni Mandar abuzachis[m] gomathiselvi jillr markuman tremble
17:42:45 <abuzachis[m]> Is this the first topic https://github.com/ansible/community/issues/687#issuecomment-1488155633?
17:43:44 <tremble> Black?
17:43:57 <abuzachis[m]> yes
17:44:21 <tremble> #topic Black formatting
17:45:08 <tremble> #info We've now merged changes which applied the "black" formatting style to all plugins and unit tests
17:45:39 <tremble> https://github.com/ansible-collections/amazon.aws/
17:45:52 <tremble> https://github.com/ansible-collections/community.aws/pull/1784
17:46:14 <tremble> https://github.com/ansible-collections/amazon.aws/pull/1465
17:46:56 <tremble> (technically the aws_ssm connection plugin was pending, I was hoping to avoid asking jillr to override Zuul)
17:47:03 <tremble> s/was/is/
17:47:59 <tremble> I'm also looking at switching to f-strings for consistency, but I think that can wait until 7.0.0 if it's not ready.
17:48:05 <jillr> I don't mind  :)  send me PRs
17:49:00 <tremble> It was more a "principle" thing, I'd rather the tests were running consistently
17:49:10 <jillr> valid
17:49:22 <tremble> some tests have been a little flaky
17:50:37 <tremble> And some tests seem to have been broken by AWS or AMIs not being shared any more
17:50:41 <tremble> (Broken without the changes too)
17:51:32 <markuman[m]> The safest way for AMI usage is to use the ssm lookups, provided by AWS itself
17:52:11 <tremble> Yeah, we do that for some of them, I think I couldn't find Fedora last I looked
17:52:29 <jillr> do we have a reusable role that does the AMI lookups or are we reproducing the tasks in every test suite? I don't recall
17:52:51 <tremble> There's a role that finds a common AMI for use
17:52:59 <jillr> thx
17:53:05 <markuman[m]> tremble: Do we have tests that depend in fedora?
17:53:11 <tremble> aws_ssm is a special case because we launch various different AMIs
17:53:27 <markuman[m]> * Do we have tests that depend on fedora?
17:53:57 <markuman[m]> Ah yeah
17:54:42 <tremble> aws_ssm and something in amazon.aws (EC2 inventory IIRC)
17:55:45 <tremble> However, we have some bust tests, but they didn't break because of black - they were already broken.
17:56:01 <tremble> There should be open issues
17:56:39 <tremble> One last thing that should happen is updating the docs to mention that we're using the black style now.
17:57:00 <tremble> ( I'm sure Goneri will be happy ;) )
17:57:39 <abuzachis[m]> tremble: Yep, that makes sense.
17:58:17 <gomathiselvi[m]> Should wee add a GitHub Action workflow for black formatting ? As of now we have a workflow for darker
17:58:20 <tremble> Looking at time, unless someone has strong views I suggest we move to https://github.com/ansible/community/issues/687#issuecomment-1497785890
17:58:45 <tremble> gomathiselvi: We can switch out darker for black
17:59:30 <abuzachis[m]> I guess Aubin was working on something using pre-commits with black (If I am not mistaken)
18:00:45 <tremble> Possibly.  Configs for black are in the repos, so just running "black plugins/ tests/" will apply the right things
18:00:58 <tremble> Any objections to shifting topic?
18:01:06 <abuzachis[m]> Nope!
18:02:24 <abuzachis[m]> #topic Structured point releases
18:02:56 <tremble> #topic Structured point releases
18:02:57 <tremble> abuzachis: Your topic
18:03:22 <abuzachis[m]> #info We would like to have a regular release process for the collections. A proposal is a monthly cadence release every fourth Tuesday of the month.
18:04:05 <abuzachis[m]> I've seen your comment tremble  and for me works that too. Any other suggestions?
18:04:41 <tremble> (My comment = First Tuesday of the month as minor release day)
18:06:12 <tremble> I like the idea of having a planned cadence.  First Tuesday will generally be just after the 4th Thursday (this meeting) which gives us time for a quick review/go-no-go
18:06:58 <abuzachis[m]> Works for me!
18:07:21 <abuzachis[m]> jillr: ? the others?
18:08:12 <jillr> no objections from me.  iirc suggesting 4th Tuesday was just to replicate what the Network folks do, for the sake of having an initial suggestion to discuss.
18:08:29 <jillr> mgraves[m]: thoughts on release proposal? ^^
18:09:22 <abuzachis[m]> Does this matches The Bullhorn?
18:09:29 <abuzachis[m]> s/matches/match/
18:09:58 <abuzachis[m]> I mean for the release notifications.
18:10:41 <tremble> They're late in the month (today's the deadline)
18:11:26 <abuzachis[m]> Ok, got it.
18:12:48 <mgraves[m]> that sounds fine to me
18:14:15 <abuzachis[m]> Ok, does it make sense to add a note on the release date somewhere (in the README)?
18:14:36 <abuzachis[m]> * release date/cadence somewhere
18:14:42 <tremble> yes
18:15:59 <abuzachis[m]> Ok, I can add that note.
18:16:59 <abuzachis[m]> if you do not have anything else to add here, we can switch topic then. I guess that it's yours tremble
18:17:35 <tremble> #topic github discussions
18:17:44 <abuzachis[m]> s/yours/your/
18:18:46 <tremble> Looking at how we've been a little flakey on meetings, how do folks feel about moving some of the initial discussions to GitHub discussions, so some discussion can happen outside of these monthly meetings
18:19:14 <tremble> This means that when folks can't make the meeting, their basic opinions on a topic can still be heard. (I'm not a big fan of using issues for this)
18:22:00 <jillr> given that the community team is making progress on standing up a Discourse instance (https://github.com/ansible-community/community-topics/issues/202) does it make sense to adopt GH discussions now, or should we plan to have a Discourse channel asap?
18:22:35 <jillr> just trying to think ahead and avoid creating confusion, if we change communication forums too often that could be problematic for contributors
18:23:06 <tremble> I'd be good with discourse.  We can shelve this for now, I don't think this is urgent, and if there's a "common" forum I'd rather we were consistent.
18:23:43 <jillr> in the interim we could think about what we would want from that forum, since it looks like from the last comment Greg is looking for feedback from projects
18:25:12 <tremble> #info Community team is working on an Ansible Discourse instance, looks like we should wait a little to avoid multiple changes.
18:25:43 <tremble> #info Gwmngilfen would love extra feedback around how we'd like to use such a tool.
18:26:35 <tremble> Move on to 5.5.0 / 6.0.0 review?
18:26:39 <abuzachis[m]> Yes
18:26:52 <tremble> #topic 5.5.0 - quick review
18:27:59 <tremble> #info abuzachis is backporting some PRs from main into stable-5 which we should try to get into 5.5.0 and prior to 6.0.0
18:28:02 <tremble> Anyone got any other PRs they really want to see in 5.5.0 ?
18:30:15 <abuzachis[m]> Quick one https://github.com/ansible-collections/amazon.aws/pull/1475
18:30:43 <abuzachis[m]> And I knot Mandar Kulkarni had also one
18:30:55 <abuzachis[m]> s/knot/know/
18:30:55 <MandarKulkarni[m> maybe this one too https://github.com/ansible-collections/amazon.aws/pull/1457
18:31:49 <tremble> I think I might have backported tha already
18:32:11 <abuzachis[m]> Yes, it has been backported already
18:32:21 <abuzachis[m]> https://github.com/ansible-collections/amazon.aws/pull/1459
18:32:24 <tremble> Ah abuzachis did, I reviewed
18:34:09 <abuzachis[m]> This one too https://github.com/ansible-collections/amazon.aws/pull/1482 if we manage to merge it
18:36:10 <tremble> markuman: Any wishlist reviews (or issues) for 5.5.0?
18:37:55 <abuzachis[m]> I would suggest these two https://github.com/ansible-collections/community.aws/pull/1790 https://github.com/ansible-collections/community.aws/pull/1788 if they make sense for markuman
18:38:11 <markuman[m]> Currently none
18:39:50 <tremble> Ok, let's see if we can get these across the line for 5.5.0
18:40:27 <abuzachis[m]> Do we want to set any release date for 5.5.0?
18:41:24 <tremble> Planning 5.5.0 for the first Tuesday - May 2nd ?
18:43:09 <abuzachis[m]> Since may 1st is holiday, we can probably delay by another day, just to have enough time
18:43:17 <abuzachis[m]> s/may/May/
18:43:45 <tremble> Sure
18:44:03 <abuzachis[m]> 👍️
18:45:36 <tremble> Move on to 6.0.0... ?
18:45:39 <abuzachis[m]> sure!
18:46:06 <abuzachis[m]> #topic 6.0.0 - quick review
18:47:16 <tremble> I think all the big ticket items are in, and it's a case of finishing off 5.5.0, releasing that and then preparing 6.0.0...
18:47:35 <abuzachis[m]> Agree!
18:47:56 <abuzachis[m]> But we also would like to have https://github.com/ansible-collections/amazon.aws/pull/1446 into 6.0.0
18:48:50 <abuzachis[m]> I know Helen Bailey was working to add integration tests.
18:50:12 <abuzachis[m]> Can you please pint this PR to the 6.0.0 milestone?
18:50:12 <abuzachis[m]> s/pint/pin/
18:50:39 <tremble> Those are however new modules, there wouldn't be a problem getting them into a 6.1.0
18:52:01 <abuzachis[m]> Since we have already added a bunch of new backup_* modules already, we wanted to release those all together. jillr mgraves any thoughts?
18:53:35 <tremble> My only concern is the Ansible 8 freeze
18:53:41 <mgraves[m]> if we need to push the remaining backup modules to 6.1.0 we can
18:54:05 <mgraves[m]> as tremble said, the more important thing is to make sure we get the 6.0.0 release into ansible 8
18:54:08 <abuzachis[m]> We would release 6.0.0 before the freeze in any case.
18:54:53 <abuzachis[m]> Talking about release date for 6.0.0, what about Monday May 8th?
18:55:14 <tremble> 2023-05-15:
18:55:14 <tremble> Last day for collections to make backwards incompatible releases that will be accepted into Ansible-8. This includes adding new collections to Ansible 8.0.0; from now on new collections have to wait for 8.1.0 or later.
18:55:53 <tremble> May 8th or 9th sounds good to me.  But we might need to be ruthless
18:56:16 <abuzachis[m]> mgraves[m]: Ok, so we can try for 6.0.0, otherwise we can point the next minor release.
18:58:33 <abuzachis[m]> Any objections for May 8th or 9th for 6.0.0 release?
19:00:24 <tremble> I'd say 9th, don't like planning for Mondays ;)
19:00:35 <tremble> (or Fridays)
19:02:48 <abuzachis[m]> works for me 👍️
19:02:48 <abuzachis[m]> Is there anything else you would like to add on this topic or in general?
19:03:35 <tremble> nope.
19:04:37 <abuzachis[m]> If not, I would say we can end the meeting.
19:06:12 <abuzachis[m]> #endmeeting